new(vitessio/vitess): horizontally-scalable MySQL (CNCF graduated)#13090
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
YAML treats `{` as the start of a flow-mapping. Without quoting, the
parser bails on `{{prefix}}/bin/...` with "did not find expected '-'
indicator". Quoting forces a plain scalar.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
4 tasks
Previous `provides:` listed 21 binaries but `make build` (via
`go build ./go/...`) actually produces 24 — vtadmin (Go API server),
rulesctl, and vtgateclienttest were being built and copied to
{{prefix}}/bin by the existing `find bin ... -exec cp` line, but
not declared in provides:.
Adds the 3 missing entries and groups provides: by function for
readability. NOVTADMINBUILD=1 is kept (gates the React web UI
which needs node.js+npm, not the Go binary) but now the recipe's
header comment explains explicitly what it does and what it
doesn't, so future maintainers don't think we're trimming the
admin tooling.
Test step gains smoke-checks for the 3 newly-declared binaries.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The smoke check `$B --help 2>&1 | head -1` failed with exit 141 (SIGPIPE). vtgateclienttest is a test harness — it prints a description and exits non-zero on --help, and the `head -1` pipe closes early, hitting the binary with SIGPIPE on the way out. Wrap the smoke loop in `set +e` and ignore the pipe exit so we just verify the binaries are on PATH and produce output. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a pkgx pantry recipe for Vitess — a CNCF-graduated database clustering system for horizontal scaling of MySQL, used in production at YouTube, Slack, GitHub, HubSpot and others.
https://github.com/vitessio/vitess/archive/refs/tags/{{version.tag}}.tar.gzmake build(not rawgo build) so upstream's ldflag-driven version embedding (tools/build_version_flags.sh) and CGO defaults stay consistent with what Vitess ships.NOVTADMINBUILD=1skips the VTAdmin web UI subbuild (would otherwise need Node + npm).BUILD_GIT_REV/BUILD_GIT_BRANCHare honored bybuild_version_flags.shto inject build info without a real git history — butbuild.envstill callsgit config core.hooksPath, so we bootstrap a throwaway repo (git init -q+ empty commit) before invoking make.build.skip: fix-patchelf— pure-Go static binaries, no need to patchelf.provides:enumerates the ~21 main binaries actually emitted tobin/pergo/cmd/*in the upstream tree (vtgate, vtctld, vttablet, mysqlctl, mysqlctld, vtorc, vtcombo, vtexplain, vtbackup, vtbench, vtclient, vtctl, vtctlclient, vtctldclient, vttestserver, vttlstest, vtaclcheck, topo2topo, zk, zkctl, zkctld).Test plan
+linux/x86-64,+linux/aarch64,+darwin/x86-64,+darwin/aarch64vtgate --versiontest step printsVersion: <semver> ...and matches{{version}}vtctldclient --versionruns cleanly🤖 Generated with Claude Code