Defer automargin during scroll-wheel zoom#7815
Open
keilogic wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_replottingguard that pan drag already uses, then letdragTail()release it before the final relayoutPlots.doAutoMarginis not called during the wheel event and is called after the debounced relayoutWhy
In #6235, scroll zoom can jitter when tick-label width changes and automargin resizes the plot while the wheel interaction is still in progress. Deferring automargin until the final debounced relayout keeps the plot box stable during the scroll interaction.
Fixes #6235.
Validation
npx @biomejs/biome lint src/plots/cartesian/dragbox.js test/jasmine/tests/cartesian_interact_test.jsnpm run test-jasmine -- cartesian_interact --nowatch --report-specshould defer automargin while zooming via mouse wheelregression passed.should compute correct multicategory tick label span during drag(436.3244vs expected430 ± 5.5).Bounty note
If the $100 PayPal/Venmo offer in #6235 still applies after this is accepted/merged, PayPal is available at https://www.paypal.com/paypalme/aogkft.