Poll for changes

[whatyoubendoing]

Use polling to monitor for changes. Omitting the interval will default
to 100ms. This option is useful if you're watching an NFS volume. Fixes #13

[danhayden]

This PR fixes an issue we are having on windows machines. Any update on if/when this will be merged?

[watilde]

interval should be Number in the chokidar/lib/nodefs-handler.js#150. How about to update this part to the following?

if (typeof argv.poll === 'number') {
  opts.usePolling = true;
  opts.interval = argv.poll;
}

[RyanZim]

@watilde Should be:

  if (argv.poll) {
    opts.usePolling = true;
  }
  if (typeof argv.poll === 'number') {
    opts.interval = argv.poll;
  }

So that:

Omitting the interval will default to 100ms.

See https://github.com/paulmillr/chokidar#performance.

[watilde]

Hello Benjamin! Thanks for the nice feature patch! It will be LGTM immediately when you update the code on the point I left a comment and add a test code :)

// and thanks for letting me know this! @danhayden

[RyanZim]

@B3njamin ping?

[whatyoubendoing]

Hey unfortunately 😢 I don't have time to fix the above or write any tests. Is someone else able to do this.

• Ben

[RyanZim]

I can fix the code, just not sure how to go about writing tests.

@watilde What did you have in mind for tests?

[watilde]

@B3njamin Sure thing! Take your time :)

@RyanZim Thank you so much for your help! Could you please cherry-pick his commit and recreate a pull request if you are available on it? For test: we can add new case that uses the poll option.

[RyanZim]

Changes made at: https://github.com/RyanZim/postcss-cli/tree/poll. Need to write tests yet.

[RyanZim]

@B3njamin @watilde: PR made: #39.

[watilde]

This is shipped as 59e6621. Thank you so much putting this together!