Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "postil-cli"
version = "0.8.15"
version = "0.8.16"
edition = "2024"
description = "Postil: a low-noise AI review gate. Silent on clean PRs, hard gate on real risk."
license = "Apache-2.0"
Expand Down
104 changes: 102 additions & 2 deletions src/envelope.rs
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@ fn normalize_publication_body_line(value: &str, index: usize) -> String {
normalized.push_str(&line[..first_content]);
normalized.push('\\');
normalized.push_str(&line[first_content..]);
normalized
neutralize_unmatched_backticks(&sanitize_publication_line(&normalized))
}

fn sanitize_publication_title(value: &str) -> String {
Expand All @@ -734,7 +734,8 @@ fn sanitize_publication_title(value: &str) -> String {
}
})
.collect::<String>();
let line = sanitize_publication_line(&single_line).replace(['`', '*', '[', ']', '#'], " ");
let line =
sanitize_publication_plain_line(&single_line).replace(['`', '*', '[', ']', '#'], " ");
let characters = line.chars().collect::<Vec<_>>();
let line = characters
.iter()
Expand All @@ -756,6 +757,16 @@ fn sanitize_publication_title(value: &str) -> String {
}

fn sanitize_publication_line(value: &str) -> String {
let text = escape_unsafe_unicode(value)
.chars()
.filter(|character| !character.is_control() || *character == '\t')
.collect::<String>()
.replace('@', "@");
let text = escape_html_outside_inline_code(&text);
neutralize_markdown_images(&text)
}

fn sanitize_publication_plain_line(value: &str) -> String {
let text = escape_unsafe_unicode(value)
.chars()
.filter(|character| !character.is_control() || *character == '\t')
Expand All @@ -766,6 +777,64 @@ fn sanitize_publication_line(value: &str) -> String {
neutralize_markdown_images(&text)
}

fn escape_html_outside_inline_code(value: &str) -> String {
let characters = value.chars().collect::<Vec<_>>();
let mut output = String::with_capacity(value.len());
let mut cursor = 0;
while cursor < characters.len() {
if characters[cursor] != '`' {
match characters[cursor] {
'<' => output.push_str("&lt;"),
'>' => output.push_str("&gt;"),
character => output.push(character),
}
cursor += 1;
continue;
}

let preceding_backslashes = characters[..cursor]
.iter()
.rev()
.take_while(|character| **character == '\\')
.count();
let width = characters[cursor..]
.iter()
.take_while(|character| **character == '`')
.count();
if preceding_backslashes % 2 == 1 {
output.extend(characters[cursor..cursor + width].iter());
cursor += width;
continue;
}

let mut candidate = cursor + width;
let mut closing = None;
while candidate < characters.len() {
if characters[candidate] != '`' {
candidate += 1;
continue;
}
let candidate_width = characters[candidate..]
.iter()
.take_while(|character| **character == '`')
.count();
if candidate_width == width {
closing = Some(candidate + width);
break;
}
candidate += candidate_width;
}
if let Some(end) = closing {
output.extend(characters[cursor..end].iter());
cursor = end;
} else {
output.extend(characters[cursor..cursor + width].iter());
cursor += width;
}
}
output
}

fn escape_unsafe_unicode(value: &str) -> String {
let mut output = String::with_capacity(value.len());
for character in value.chars() {
Expand Down Expand Up @@ -1817,6 +1886,37 @@ mod tests {
assert_eq!(validate_finding_publication(&finding), Ok(()));
}

#[test]
fn fresh_finding_normalization_preserves_operators_in_inline_code() {
let mut finding = finding(Severity::Warn, 0.9);
finding.body = "The expression `time() - kube_pod_start_time > 60d` measures pod age, while <details> remains markup.".into();

normalize_finding_publication(&mut finding);

assert!(
finding
.body
.contains("`time() - kube_pod_start_time > 60d`")
);
assert!(!finding.body.contains("&gt; 60d`"));
assert!(finding.body.contains("&lt;details&gt;"));
assert_eq!(validate_finding_publication(&finding), Ok(()));
}

#[test]
fn fresh_finding_normalization_is_idempotent_for_fence_shaped_code() {
let mut finding = finding(Severity::Warn, 0.9);
finding.body = "``` <details> ```.".into();

normalize_finding_publication(&mut finding);
let normalized = finding.body.clone();

assert_eq!(normalized, "\\``` &lt;details&gt; ```.");
assert_eq!(validate_finding_publication(&finding), Ok(()));
normalize_finding_publication(&mut finding);
assert_eq!(finding.body, normalized);
}

#[test]
fn fresh_finding_normalization_does_not_hide_semantic_contract_failures() {
let mut incomplete = finding(Severity::Warn, 0.9);
Expand Down
9 changes: 8 additions & 1 deletion src/forge/github.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3065,7 +3065,11 @@ mod tests {
async fn github_receipt_separates_inline_summary_carried_resolved_and_suppressed() {
let server = MockServer::start().await;
mount_current_delivery_snapshot(&server).await;
let inline = publication_finding("inline-1", "src/lib.rs", "A concrete issue.");
let inline = publication_finding(
"inline-1",
"src/lib.rs",
"The expression `time() - kube_pod_start_time > 60d` measures pod age.",
);
let synthetic = publication_finding(
"summary-1",
crate::envelope::PR_DESCRIPTION_PATH,
Expand Down Expand Up @@ -3164,6 +3168,9 @@ mod tests {
.unwrap();
let initial_summary = review["body"].as_str().unwrap();
assert!(!initial_summary.contains("posted inline"));
let inline_body = review["comments"][0]["body"].as_str().unwrap();
assert!(inline_body.contains("`time() - kube_pod_start_time > 60d`"));
assert!(!inline_body.contains("&gt; 60d`"));
let update: serde_json::Value = serde_json::from_slice(
&requests
.iter()
Expand Down