Configurable bucket count cache duration#695
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 12ba7e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rkistner
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b136e8ad0c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
stevensJourney
approved these changes
Jun 29, 2026
stevensJourney
left a comment
stevensJourney
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases the bucket checksums and counts are expensive to calculate, so this helps reduce the overhead.
Note that this is a "TTL after use", not "TTL after calculation". So there may be some cases where the cached value is persisted for a long time.
Using a cached value should never result in an incorrect checksum. The main caveat of a longer TTL is that the count may be incorrect after a compact operation, resulting in client-side progress bars being slightly inaccurate. This is why I call this the "bucket count cache" duration instead of "checksum cache" duration.
The default here is still 60 minutes, but it can be increased to a couple of hours without significant risk.