Conversation
hackartisan
reviewed
Jul 14, 2026
hackartisan
left a comment
hackartisan
left a comment
Contributor
There was a problem hiding this comment.
We looked at this in a PR review ensemble. We're interested in whether this could be made more backwards compatible.
- could we check first for the spotlight namespaced config, then fall back if it's not found?
- could we use an initializer to pull the configs we expect to find into a spotlight namespace?
- other ideas?
jcoyne
force-pushed
the
encapsulate_config
branch
from
July 14, 2026 19:06
71e5251 to
5dd4a6b
Compare
All values set on Spotlight::Engine.config are actually stored in a class variable on Railtie::Configuration. So these pollute that namespace. All other railties are encapsulating their configs onto a single entry in that scope. This change makes Spotlight do likewise. This probably needs to be a major revision
jcoyne
force-pushed
the
encapsulate_config
branch
from
July 15, 2026 15:38
5dd4a6b to
9b545a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All values set on Spotlight::Engine.config are actually stored
in a class variable on Railtie::Configuration. So these pollute
that namespace. All other railties are encapsulating their configs
onto a single entry in that scope. This change makes Spotlight do
likewise.
This probably needs to be a major revision