Skip to content

Let the Read Be the Check in the checks/ Gates That Probe First #546

Open

Description

@ptr727

Summary

The carried CODESTYLE.md "Operations and Failure Messages" rule says to let the real operation be the check, and not to probe first with an existence test. These gates probe and then read:

  • checks/env_docs_gate.py, the DOC.exists() check before reading the environment doc
  • checks/media_redactions_gate.py, the path.is_file() check before reading the manifest
  • checks/text_pii_gate.py, both path.is_file() checks before reading
  • checks/url_parity_gate.py, the robots.is_file() and home.is_file() checks before reading

Each reads a trusted file from this repository's own build, so this is conformance with the carried style rule rather than a hardening need. GOVERNANCE.md "Design Before Code" moves sites in files a change does not touch in a change of their own, filed as one issue naming each, which is this issue.

Done

Each site opens or reads the file directly and reports the failure that operation raises, with the same message quality the probe gives today. The unit suite under checks/tests/ still passes, and any test that asserts the probe's message is updated to the new one.

Found by the local strict review of the instruction-set resync for #540.

🤖 Generated with Claude Code

Activity

  1. added
    choreRegistry, labels, rollout, and other fleet housekeeping
    pre-existingReview finding classed pre-existing per local-strict-review Disposing of Findings
    on Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    choreRegistry, labels, rollout, and other fleet housekeepingpre-existingReview finding classed pre-existing per local-strict-review Disposing of Findings

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions