Skip to content

Print a Proxied Verdict for Every Host the Check Reaches - #503

Merged
ptr727 merged 3 commits into
developfrom
docs/proxy-probe-verdict
Oct 24, 2026
Merged

ptr727 merged 3 commits into
developfrom
docs/proxy-probe-verdict

Conversation

@ptr727

@ptr727 ptr727 commented Oct 24, 2026

Copy link
Copy Markdown
Owner

Summary

This fixes the Copilot round on promotion #502 (head 4493967), thread on OPERATIONS.md:137.

  • The proxy probe gives a verdict for every host. It printed header lines and left the reader to judge them, and it named one host. It now loops over the blog and family hosts. It prints <host> proxied only when a host answers both server: cloudflare and cf-ray, and <host> UNCONFIRMED otherwise, a curl failure included. The gate says to go ahead only when each host prints proxied. This "require both headers" point came up on Confirm the Proxy Headers Before Calling a Run Proxied #498 and again on Promote Consistent Site Security Headers and the Proxied-Run Check #502, so the doc now states it outright instead of leaving it to the reader.
  • HSTS nit from the same round. The includeSubDomains reason in deploy/README.md now says plainly that it extends the policy to subdomains of the site's hostname.

Verification

  • Ran the loop against the live hosts. The proxied production names print proxied. A DNS-only host answering 401 prints UNCONFIRMED, and so does an unreachable port.
  • prose_lint.py --diff and its sentence-length check are clean.

Local review

The first pass raised one introduced finding. The failure verdict NOT proxied contained proxied, so a test for the word passed on a failure. Fixed in f12a2dd with UNCONFIRMED. The second pass found nothing.

🤖 Generated with Claude Code

ptr727 and others added 2 commits October 24, 2026 08:09
The probe printed the matching header lines and left the reader to
judge them, and it named one host. It now prints proxied only when a
host answers both server: cloudflare and cf-ray, and it covers the
family host too. The includeSubDomains reason now says plainly that it
names subdomains of the site's hostname.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 24, 2026 15:14
@ptr727

ptr727 commented Oct 24, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head f12a2dd00c44dccd7eb4deefe97f97b75620e573, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: e83833c0-2f29-4361-9ebc-ffac5e8362d5
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.70%. Comparing base (4493967) to head (d0109be).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #503   +/-   ##
========================================
  Coverage    49.70%   49.70%           
========================================
  Files           10       10           
  Lines         3058     3058           
========================================
  Hits          1520     1520           
  Misses        1538     1538           
Flag Coverage Δ
python-3.13 49.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The documented probe still has unresolved portability, header-matching, timeout, and curl-failure handling issues.

1 open issue
What changed in this PR

This pull request updates deployment documentation to provide explicit Cloudflare proxy verdicts for both site hosts and clarifies HSTS subdomain coverage.

Changes:

  • Adds per-host checks for the blog and family hosts.
  • Reports proxied only when both required Cloudflare headers are present; otherwise reports UNCONFIRMED.
  • Clarifies that HSTS includeSubDomains applies to subdomains of the site's hostname.
File Description
OPERATIONS.md Documents per-host Cloudflare proxy verification and verdict output.
deploy/​README.md Clarifies the HSTS includeSubDomains explanation.

Review effort: Lite

Comment thread OPERATIONS.md Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Oct 24, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head d0109bec55d3f14736a8db20bcfb67ff435d7abd, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@ptr727

ptr727 commented Oct 24, 2026

Copy link
Copy Markdown
Owner Author

Answering the outdated thread on OPERATIONS.md:139 (use POSIX syntax in the sh probe): fixed in d0109be. Each here-string is now printf '%s\n' "$h" | grep -qi ..., so the block runs under /bin/sh. Under dash against live hosts, it printed proxied for proxied names and UNCONFIRMED for a DNS-only host and an unreachable port.

@ptr727
ptr727 merged commit 64b8793 into develop Oct 24, 2026
12 checks passed
@ptr727
ptr727 deleted the docs/proxy-probe-verdict branch October 24, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants