Conversation
Updated [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 18.6.0 to 18.7.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.NET.Test.Sdk's releases](https://github.com/microsoft/vstest/releases)._ ## 18.7.0 ## What's Changed * Add ARM64 msdia140.dll support to test platform packages by @jamesmcroft in microsoft/vstest#15689 * Update System.Memory from 4.5.5 to 4.6.3 by @nohwnd in microsoft/vstest#15706 ## New Contributors * @jamesmcroft made their first contribution in microsoft/vstest#15689 **Full Changelog**: microsoft/vstest@v18.6.0...v18.7.0 Commits viewable in [compare view](microsoft/vstest@v18.6.0...v18.7.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Carry the template's artifact-storage hygiene into the workflows: - Add a terminal `cleanup-artifacts` job to publish-release.yml (needs setup/publish/date-badge) and test-pull-request.yml (needs smoke-build) so a run's artifacts are deleted via the REST API instead of accumulating against the account-wide storage quota. - Converge the github-release handoff to the canonical name-pattern form (ptr727/ProjectTemplate#203, decided option a): build-nugetlibrary uploads `release-asset-<branch>-nugetlibrary` and drops the `artifact-id` output/plumbing; build-release downloads by `pattern:` + `merge-multiple:`. This keeps the github-release job a verbatim carry. - Document both in AGENTS.md (Workflow YAML Conventions) so this single-target repo stops drifting back to the id-based variant. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Strip inline comments that only restate self-evident code (`// Done`, `// Sort variants`, `// Add … tag`, the SetCase casing labels, etc.) per the AGENTS.md "comment only when the code does not explain itself" rule. RFC 5646 section URLs, ABNF grammar blocks, fallback-chain labels, and any "why" notes are kept. Removing a trailing `// Done` unblocked analyzer IDE0046 at the end of Validate(), so the final `if (…) return false; return true;` collapses to a single `return !string.IsNullOrEmpty(…);` (required: the husky gate runs `dotnet format style --severity=info`). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Maintenance-only promotion that re-syncs GitHub Actions workflows with the upstream template and trims self-evident inline comments in core parsing/lookup code, while also carrying a small test dependency bump.
Changes:
- Reworked release-asset artifact handoff to a pattern-based download (
release-asset-<branch>-*) and removed the artifact-id output plumbing. - Added terminal
cleanup-artifactsjobs to delete run artifacts via the REST API to reduce account-wide artifact storage accumulation. - Removed redundant inline comments in
LanguageTagParser/LanguageLookupand simplified the tail ofLanguageTagParser.Validate(); bumpedMicrosoft.NET.Test.Sdkto 18.7.0.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| LanguageTags/LanguageTagParser.cs | Removes redundant comments and simplifies Validate()’s final empty-tag check without changing behavior. |
| LanguageTags/LanguageLookup.cs | Removes self-evident inline comments while keeping behavior unchanged. |
| Directory.Packages.props | Bumps Microsoft.NET.Test.Sdk from 18.6.0 to 18.7.0. |
| AGENTS.md | Documents the canonical artifact handoff pattern and the new cleanup-artifacts convention. |
| .github/workflows/test-pull-request.yml | Adds best-effort cleanup-artifacts job to delete any run artifacts without gating the required status check. |
| .github/workflows/publish-release.yml | Adds best-effort cleanup-artifacts job gated to real publishes to delete run artifacts after publishing. |
| .github/workflows/build-release-task.yml | Switches GitHub release asset download to pattern-based download-artifact with merge-multiple. |
| .github/workflows/build-nugetlibrary-task.yml | Renames uploaded artifact to release-asset-<branch>-nugetlibrary and removes artifact-id outputs. |
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintenance-only promotion of
developtomain. Noversion.jsonchange, somainadvances only its NBGV height.Template re-sync (
dd19d31)Addresses ptr727/ProjectTemplate#203.
cleanup-artifactsjob topublish-release.yml(needs setup/publish/date-badge) andtest-pull-request.yml(needs smoke-build) so a run's artifacts are deleted via the REST API instead of accumulating against the small account-wide storage quota. Best-effort:continue-on-error,always(), kept out of the required status check.github-releasehandoff to the canonical form:build-nugetlibrary-task.ymluploadsrelease-asset-<branch>-nugetlibraryand drops theartifact-idoutput/plumbing;build-release-task.ymldownloads bypattern:+merge-multiple:. This keeps thegithub-releasejob a verbatim carry rather than forking its download step.Comment cleanup (
e104dbb)Strip inline comments that only restate self-evident code from
LanguageTagParser.csandLanguageLookup.cs, per the "comment only when the code does not explain itself" rule. RFC 5646 section URLs, ABNF grammar, fallback-chain labels, and "why" notes are kept. Removing one trailing// Doneunblocked analyzer IDE0046, collapsing the tail ofValidate()to a single expression.(Also carries the earlier
Bump the nuget-deps groupdependency PR already ondevelop.)Verification
dotnet format style --severity=infoexit 0, CSharpier clean, 257/257 tests pass.🤖 Generated with Claude Code