Repository navigation
D3.4 requires a develop .dev0 build to sort above the default release, which NBGV's longest-path height does not guarantee #1532
Description
Activity
Settled already, by #1528, so this is closed with no change of its own.
WORKFLOW.mdD3.4 and the section 6pypiwalkthrough dropped the ordering promise and thepip install --pre-selectable wording in "Drop the Promise That the develop .dev0 Build Sorts Above the Default Release" (#1528), squash-merged as765633d, which is on bothdevelopandmain. That change settled the ordering item of #1522, which this issue restates. Current D3.4 says only that PyPI builds from theX.Y.Zcore ofSemVer2, prerelease and build segments dropped, with.dev0appended ondeveloponly, and it asserts nothing about how that version sorts against the default release. The two comment lines in.github/actions/pypi-build-default/action.ymlthat rested on the same claim were deleted in the same change, and theworkflow-ci-contractgenerated includes were regenerated from the corrected D3.4.A fleet-wide search of this repository for the claim finds one residual mention, in
reports/aiopurpleair/audit.md, which is a dated audit snapshot from #246 rather than a rule, and reports are not retro-edited. A re-audit of that repository is what refreshes it.The downstream exposure this issue names stays open on the downstream side rather than here:
ptr727/aiopurpleaircorrected its ownWORKFLOW.mdD3.4, but its carried.github/skills/workflow-ci-contract/references/d-guarantees.mdstill holds the pre-#1528 text and does so until that repository resyncs against the hub. That is a change to that repository, not to this one.
Defect
The canonical D3.4 in
WORKFLOW.md, carried as.agents/skills/workflow-ci-contract/references/d-guarantees.md, says thedevelop.dev0build must remainpip install --pre-selectable and sort above the default release, with NBGV git height in the release segment keepingdevelopahead. Under the fleet's branching model that doesn't hold, so no conforming repository can guarantee it.Why
NBGV version height is the longest path back to the version root, so a merge commit's height is one plus the larger of its parents'. On the release model,
maintakes merge commits only anddevelopis squash-only and linear. That gives:mainat one above whichever line is longer.mainwidensmain's lead, anddevelopnever receives those commits back.developsquash merge narrows it.Constructed example, base
1.0, no offset:mainheightdevelopheight1.0.51maindevelopprerelease dispatch1.0.42.dev01.0.42.dev0sorts below1.0.51, sopip install --prepicks the stable release. The order flips back only oncedevelop's line grows pastmain's. In ptr727/aiopurpleair#111 a real release pair measured exactly this:develop13 patches behindmainstraight after a released promotion, while at an early promotion it had been ahead.Downstream
ptr727/aiopurpleair corrected its own
WORKFLOW.mdD3.4 to say adevelopbuild is not guaranteed to sort above the latest default release, and to install one by its exact PyPI version (==X.Y.Z.dev0). Its carriedd-guarantees.mdstill states the old requirement, so an agent loadingworkflow-ci-contractthere reasserts it until the canonical text changes.Possible fix
Replace the requirement with the weaker true statement: a
developbuild is a prerelease installed by exact version, and its order against the default release depends on history length. The alternative is a versioning change that makesdeveloplead by construction, such as adevelopheight offset or a minor-version lead. That changes version semantics fleet-wide, so it's a decision rather than a rewording.