Repository navigation
Closed
Description
Defect
Whole-unit review while settling #1540 and #1539 found these statements contradicted by the tree or by WORKFLOW.md. None was introduced there, and #1524, #1527, #1531, and #1536 hold the earlier rounds' findings. Each wants checking before it is fixed, since a finding against prose can be a reading the text does not intend.
WORKFLOW.md section 3, the Orchestration bullet
- "Orchestration is generic and forms the standardization baseline at the job level: the single-branch publisher, the
get-version,validate-release, andgithub-releasejobs, and thechanges -> smoke-build -> aggregatorshape of the PR workflow. These job bodies should not need per-repo edits." The next bullet has the repo edit the publisher (theenable_<target>value it passes, itson.push.paths, apublish-<target>job) and thechangesfilter entry, output, andsmoke-buildenable-forward, all inside the job bodies this sentence says need none, and D6.4 says "verbatim" never reaches the paths-filter. The catalog publisher stub calls itself the NuGet-library shape that a Docker or PyPI repo varies. The "verbatim" the next bullet then scopes has no antecedent in the section either. - The Release Model's "a first
planjob (publish-plan-task.yml) decides once and every job gates on it" is the section 3 twin of WORKFLOW.md Sections 4 and 6 Carry Further Statements the Tree Contradicts, Found Settling #1522 #1527's D4.1 item. The hub's own.github/workflows/publish-release.ymlrunsassert-dispatch-reffirst, withplanneeding it, and that job refuses a bad ref beforeplandecides anything, while the catalog stub does start withplan.
WORKFLOW.md D4.5
- "Input: a real publish where one enabled build fails. Output: nothing publishes." does not hold when the build that fails is Docker's. The Docker leaf builds and pushes in one step per matrix leg with no cross-leg gate, and the
docker-build-basehook receivespushand runs before the image legs, so in a multi-image orbuild-baserepo a failing leg can leave base images or another leg's image already pushed whilegithub-releaseskips. That is the partial publish the item's Prevents: line rules out. The item's gating argument covers Docker waiting on the other builds, never a failure inside Docker itself.
The release skill's "Per-target subsetting" section
- "A repo still curates, in
test-pull-request.yml, its path-filter entry, that filter's output, and thesmoke-buildenable-forward, all three together per D6.4 ... And, for a package target, thepublish-nugetorpublish-pypijob" in.agents/skills/operational-vs-release-workflow/references/release-publish-mechanics.mdrestates D6.4's add/drop list and omits two of its items: the publisher'son.push.pathsentries andexpect_release_assetswhere the change adds the first file target or drops the last. A reader dropping the last file target by this list keepsexpect_release_assetsat its defaulttrue, missing the no-asset shape D4.3 requires. The neighbouring "Orchestration vs. build: the override seam" section is now a pointer toWORKFLOW.mdsection 3 for the same list, so this one could point there too rather than restating it.
Metadata
Metadata
Assignees
Labels
No labels
Activity
Name the Validate and Docker Hooks, and Point the Release Skill at Se…
Correct Section 3, 4 and 6 Statements the Tree Contradicts (#1542)
ptr727 commentedon Oct 23, 2026
Closed under the maintainer's decision (ptr727, 2026-10-23) on #3391: the backlog keeps real bugs with a stated failure, features the maintainer wants, and open decisions. A finding the review loop filed on code or text a change did not touch, a refactor or consolidation chore, a tracker, a wording item, or a guard shape no session has produced is closed rather than worked. Reopen with the input and the wrong result if this issue states one.