test_an_entry_with_a_defect_is_not_also_reported_absent plants a SessionEnd type: "prompt" and a PreToolUse matcher: "Edit", then asserts only that no problem contains "is not registered" and none contains "never runs". It never asserts the two planted defects are reported at all, so it passes unchanged if registration_problems stops reporting them entirely, which is the strictly worse regression.
Its sibling three tests above states the standard it misses: "Each shape asserts the problem it should raise rather than that it raised one, since a second and false 'not registered' line satisfied a bare truthiness check by itself."
The fix is to assert both planted defects appear alongside the existing absence assertions. Found by a local strict review pass on #1632.
test_an_entry_with_a_defect_is_not_also_reported_absentplants a SessionEndtype: "prompt"and a PreToolUsematcher: "Edit", then asserts only that no problem contains "is not registered" and none contains "never runs". It never asserts the two planted defects are reported at all, so it passes unchanged ifregistration_problemsstops reporting them entirely, which is the strictly worse regression.Its sibling three tests above states the standard it misses: "Each shape asserts the problem it should raise rather than that it raised one, since a second and false 'not registered' line satisfied a bare truthiness check by itself."
The fix is to assert both planted defects appear alongside the existing absence assertions. Found by a local strict review pass on #1632.