Skip to content

Session Handoff [auto-1901]: Keep a Folded if: Condition Visible to the Interface Audit's Token Check #1955

Closed

Description

@ptr727

Next steps, in priority order

  1. Fix The Interface Audit Cannot See a Required Token Inside a Folded If #1901: the interface audit's requireTokensInJob check searches _code_view(job) in spec/audit.py, which drops every block-scalar body, so a token carried in a folded if: >- condition (the fleet's own convention for a multi-line if:) is reported missing. Keep the body of a block scalar whose key is if:, since an if: value is an expression rather than prose, or read the token from the job's if: value directly, whichever keeps the existing prose-hiding protection for name: | and run: | bodies intact. Done looks like: the constructed case in The Interface Audit Cannot See a Required Token Inside a Folded If #1901 (a publish job whose needs.validate.result == 'success' sits inside if: >-) passes the check, a name: | body that merely mentions a required token still does not satisfy it, both covered by tests in the audit's test suite, and a pull request into develop merged with Closes on promotion: #1901 in its body.

External blockers

None known at pick time.

Internal dependencies

None. The fix is confined to spec/audit.py and its tests.

State

The parked decision queue

Empty.

What the last round did

Nothing yet. This link was created by the unattended-handoff picker from the open backlog, ranked as a correctness defect in something that runs (a false positive against callers that follow the Workflow YAML convention), new, and self-contained.

What not to repeat

Nothing yet.

New learnings

None yet.

Activity

  1. added
    handoffA link in the session handoff chain, one open issue per track
    on Sep 28, 2026
  2. ptr727 commented on Sep 28, 2026

    @ptr727
    OwnerAuthor

    Lane closed out, scope develop.

    • Merged Keep a Folded if: Condition Visible to the Interface Audit's Token Check #1956 into develop (squash 6f2cc9a), carrying Closes on promotion: #1901. The Interface Audit Cannot See a Required Token Inside a Folded If #1901 stays open until the develop -> main promotion.
    • The fix: _code_view() in spec/audit.py keeps a block-scalar if: body and folds it onto the key line, so a requireTokensInJob token in a folded if: >- condition matches, including a wrap inside the token. name: | and run: | bodies are still dropped. Self-tests cover the The Interface Audit Cannot See a Required Token Inside a Folded If #1901 case, the wrap-inside-token case, and a name: | body that must not satisfy the check. Reverting the fix fails them.
    • Review: Copilot two rounds, no findings, coverage full. CodeRabbit raised one finding (preserve YAML line breaks around more-indented folded lines), declined with evidence and resolved, since a newline between expression tokens evaluates as whitespace.
    • Known scope left as is: a multi-line plain or quoted (non-block-scalar) if: continuation is not folded. The Workflow YAML convention writes a multi-line condition as if: >-, so nothing was filed.
    • Filed nothing else. Worktree, local branch, and remote branch removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    handoffA link in the session handoff chain, one open issue per track

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions