Repository navigation
Session Handoff [auto-1877]: Fold Whitespace in pr_review.py reply --match #1973
Description
Activity
Fixed #1877 in PR #1974, merged to develop as 2462619 (squash of 034ad43).
matching_threads()now folds whitespace to a single space on both sides of the--matchcompare, the same collapsedescribe()applies before printing anunresolved:line, so a pattern copied from that printed line matches the thread it was copied from through a line break, tab, or run of spaces. Left the 120-character display cutoff as is per the issue, documenting it ondescribe()as a display limit rather than a matching concern.New regression test
test_a_pattern_copied_from_the_printed_unresolved_line_selects_its_own_thread, confirmed to fail against the pre-fix implementation and pass against the fix.unittest tests.test_pr_review(442 tests),ruff format --check,ruff check, andmypyall clean. Local adversarial review pass recorded against develop with no findings; Copilot's PR review landed with 0 unresolved/suppressed findings and full coverage.No lesson filed; no decision needed on this lane.
Next steps, in priority order
scripts/pr_review.py: makereply --matchfold whitespace in both the pattern and the thread body before the substring compare, the same collapsedescribe()applies to the printedunresolved:line, so a pattern copied from that line selects its own thread. Done looks like a test that copies a pattern from a printedunresolved:line spanning a line break or a run of spaces and selects the thread, with the fix reverted the test fails, and the pull request merged to develop withCloses on promotion: #1877in its body.External blockers
None known. The fix stays inside this repository's tree.
Internal dependencies
None. One issue, one lane.
State
Nothing started. No branch, worktree, or pull request exists for this lane. Isolate per
repo-worktreeonfeature/auto-1877from develop.The parked decision queue
0 parked decisions on this lane.
What the last round did
Created by an
unattended-handoffpicker, scope develop, from the open backlog.What not to repeat
Nothing attempted yet.
New learnings
None yet.