Skip to content

Decide How to Finish the #1947 Build-Profile Fix Past Its Review Budget #1982

Description

@ptr727

Question

The fix for #1947 on branch feature/auto-1947 (handoff #1981) reached the local review loop's two-round edit budget with two findings still open against it. How should the lane proceed?

Where it stands

The branch states the Python build profile by its trait with two forms (a uv form, and a pip form where no uv.lock is committed), scopes the clean-compile, Tests, and CI-gate uv run commands to the uv form, and says how CI runs each pip-form tool. Three local strict review passes ran. The first two raised findings that the next round fixed. The third raised two more:

  1. .agents/skills/python-codestyle/SKILL.md "Local development loop" (unchanged text) still tells any build-profile directory to run uv sync / uv run. In a pip-form directory that fails where pyproject.toml has no [project] table, and otherwise writes a uv.lock that, once committed, reclassifies the directory as uv form in CI.
  2. .agents/skills/python-codestyle/references/profiles.md, the new pip-form sentence on how CI runs the type checker, holds only for a directory declared in the validator's python-directories input. The undeclared default root installs nothing and runs a bare uvx <checker>@latest.

The skill's rule is that editing stops once an introduced finding outlives the second round, since later rounds tend to produce the findings they fix.

Options

  1. Recommended: authorize one more edit round. Scope the local development loop to the uv form, and qualify the pip-form type-check sentence to declared directories. Reason: both fixes are one clause each, and without them the branch ships a two-form definition whose surrounding commands still assume one form. The parked work continues on the same branch and drives to develop.
  2. Ship the branch as it stands and file both findings as follow-up issues. Reason: python-codestyle Profiles Reference Calls the Build Profile PEP 621, Then Admits a pyproject.toml With No [project] Table #1947's literal ask (the profile bullet no longer defines the profile by one of its forms) is met now. The parked work opens its pull request unchanged, and the two gaps stay in carried text until a follow-up lands.
  3. Narrow the branch to the profiles.md bullet alone and file the uv-command scoping as its own issue. Reason: keeps this pull request to exactly what python-codestyle Profiles Reference Calls the Build Profile PEP 621, Then Admits a pyproject.toml With No [project] Table #1947 asked. The parked work drops the SKILL.md scoping commits from this branch.

Belongs to

Handoff #1981 (track auto-1947), issue #1947. Branch feature/auto-1947, pushed. No pull request is open yet, so none is blocked.

Activity

  1. added
    decisionA question waiting on the maintainer, alone or beside whatever else the issue carries
    on Sep 28, 2026
  2. ptr727 commented on Sep 28, 2026

    @ptr727
    OwnerAuthor

    Answered by the maintainer in an attended session: option 1, one more edit round: scope the local development loop to the uv form and qualify the pip-form type-check sentence to declared directories. Work continues under handoff #1981.

  3. removed
    decisionA question waiting on the maintainer, alone or beside whatever else the issue carries
    on Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions