Repository navigation
Session Handoff [auto-1971]: Validate the Rulesets Response Before ruleset_id() Reads It (#1971) #1986
Description
Activity
Fixed and merged to develop as 8c802f3 (PR #1988, squash of 523f0b4).
ruleset_id()now validates$outis a JSON array before its per_page guard and theids=extraction read it, matching theentriesguard's own pattern, and covered by newtests/test_configure_ruleset_id.py.A local-strict-review pass over the full diff found no blocking defects: one comment-wording inaccuracy (fixed in the same commit) and one pre-existing gap in the
ids=extraction for a malformed array element, filed separately as #1987 (does not block this fix).#1971 stays open until this lands on main; closes on that promotion.
Scope for this lane was develop, so no promotion was driven here.
Next steps
repo-config/configure.shruleset_id(): validate that$outis a JSON array (jq_has 'type == "array"' <<<"$out", the pattern theentriescount site already uses) before the per_page length guard and theids=extraction read it, and abort with a "could not read live state"-style message andreturn 1on failure. Done looks like: a non-array 2xx body makesruleset_idreturn non-zero at both the apply and check call sites rather than reading as "not found", covered by a test that fails with the fix reverted.drive-pr, its body carryingCloses on promotion: #1971, then close this lane out.External blockers
None known.
Internal dependencies
None. #1880 (CR-safe
jqrrouting of the same guard) already merged to develop as #1972, so build on develop's currentruleset_id().State
No branch, worktree, or pull request yet. Work on
feature/auto-1971in a worktree of its own, based on develop.Parked decisions
None.
What the last round did
Nothing yet. This lane was opened by the unattended-handoff picker.
What not to repeat
Nothing yet.
New learnings
None yet.