Problem
The #1947 fix on feature/auto-1947 states the Python build profile by its trait and gives it a uv form and a pip form. Its second local strict review pass raised six findings on text that fix wrote or left behind in the python-codestyle skill. Per the answer on #2027, the pull request opened with the branch as it stands, and the six are filed here together.
- The pip form's local environment is never defined. The text says to run pytest "from the environment its
requirements*.txt installed", but names no command. CI does three things: uv venv, one install over every requirements*.txt together, then uv pip install -e . where [project] exists. Installing only the requirements leaves a src-layout package unimportable, so local pytest fails where CI passes.
- SKILL.md's "CI runs the same clean-compile commands" contradicts the pip-form text for the undeclared root. CI type-checks that root with a bare
uvx <checker>@latest, while the local text points the checker at the environment.
references/profiles.md says CI runs uv sync --frozen. CI runs uv sync --all-groups --frozen, which installs dependency groups but not the [project.optional-dependencies] extras the same bullet allows for dev tools.
references/profiles.md still says the profiles differ by third-party runtime dependencies showing up in pyproject.toml. That disagrees with the restated trait and with a pip form whose dependencies live in requirements*.txt.
- uv-only text the scoping missed. The Layout block's committed
uv.lock, the Type checking paragraph's uv run pyright as the CI command, and the dependency-declaration axis naming only uv mechanisms.
- The
vscode-tasks-python.json snippet has no pip-form adaptation. The skill tells a pip-form repo to adapt it, but its header names no pip-form adaptation, and its lint-only description also fits a pip-form directory, which would drop the pytest and coverage tasks the pip form owes.
Done
Each surface above describes the pip form, or is scoped to the uv form, consistently with the trait-based build profile definition and with what CI runs, and the generated skill distributions are regenerated.
Found by the second local strict review pass on feature/auto-1947 (handoff #1981, decision #2027).
Problem
The #1947 fix on
feature/auto-1947states the Pythonbuildprofile by its trait and gives it a uv form and a pip form. Its second local strict review pass raised six findings on text that fix wrote or left behind in thepython-codestyleskill. Per the answer on #2027, the pull request opened with the branch as it stands, and the six are filed here together.requirements*.txtinstalled", but names no command. CI does three things:uv venv, one install over everyrequirements*.txttogether, thenuv pip install -e .where[project]exists. Installing only the requirements leaves asrc-layout package unimportable, so local pytest fails where CI passes.uvx <checker>@latest, while the local text points the checker at the environment.references/profiles.mdsays CI runsuv sync --frozen. CI runsuv sync --all-groups --frozen, which installs dependency groups but not the[project.optional-dependencies]extras the same bullet allows for dev tools.references/profiles.mdstill says the profiles differ by third-party runtime dependencies showing up inpyproject.toml. That disagrees with the restated trait and with a pip form whose dependencies live inrequirements*.txt.uv.lock, the Type checking paragraph'suv run pyrightas the CI command, and the dependency-declaration axis naming only uv mechanisms.vscode-tasks-python.jsonsnippet has no pip-form adaptation. The skill tells a pip-form repo to adapt it, but its header names no pip-form adaptation, and its lint-only description also fits a pip-form directory, which would drop the pytest and coverage tasks the pip form owes.Done
Each surface above describes the pip form, or is scoped to the uv form, consistently with the trait-based
buildprofile definition and with what CI runs, and the generated skill distributions are regenerated.Found by the second local strict review pass on
feature/auto-1947(handoff #1981, decision #2027).