Skip to content

D4.1 and Its Restatements Say a Human Merge Never Auto-Publishes, Which the D4.7 Window Contradicts #2085

Description

@ptr727

Summary

WORKFLOW.md D4.1 states in bold that "A human merge never auto-publishes", with no exception. The D4.7 supersede step leaves a window where one does: a push landing after the step's git ls-remote re-check and before gh workflow run is built and released by the dispatched run without the actor-allowlist check, since a dispatch runs whatever the branch head is when it is created. That push can be a human merge.

The #2009 change names this window in D4.7 and S14. It leaves D4.1 unchanged, because the same unqualified wording is stated on several other surfaces, and qualifying one of them alone would put them in disagreement.

Surfaces carrying the unqualified wording

  • WORKFLOW.md D4.1, and the section 3 overview sentence "A human merge never auto-publishes"
  • .agents/skills/branching-and-release-model/SKILL.md, and its generated copies
  • docs/reusable-workflows.md, which cites D4.1 for it
  • the header comment in .github/workflows/publish-plan-task.yml

GOVERNANCE.md "Release Model" says "a human merge never auto-publishes on its own", which arguably still holds, since in the window the merge rides a bot's re-dispatch.

Suggested direction

Either qualify every surface above consistently, naming the D4.7 window as the one exception, or close the window itself, for example by passing the checked SHA through a dispatch input so the dispatched run refuses a head that moved. The second is a behavior change on every publisher stub.

Found by a local strict-review pass while working #2009.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions