Skip to content

Settle Two Review Findings on the HomeAutomation-Config Rollout Tracking Fix (#1779) #2166

Description

@ptr727

Question

The fix for #1779 is on branch feature/auto-1779 (pushed, no pull request yet), and the two review rounds of edits allowed for a push are spent. The last pass still raised two findings on text this change wrote. How should they be settled?

  1. In TODO.md "Outstanding" for the merge-bot, the sentence says HomeAutomation-Config "piloted the direct-to-develop path in that adoption". The tracker elsewhere ticks a pilot proof only with a run URL, so the claim cites no run. Two merge-bot runs on Dependabot PRs into develop while the repo was operational exist (2026-09-20 and 2026-09-23 in HomeAutomation-Config's Actions).
  2. In docs/reusable-workflows.md Stage 2, ticking the second pilot fires the trigger of the next item ("one checkbox each added when the pilots close"), and no per-repo checkboxes were added.

Options

  1. Recommended: cite one of those runs in the TODO.md sentence, and reword the "remaining repos" item so it no longer says the checkboxes wait on the pilots closing. Effect: one more small commit, one more review pass, then the pull request into develop with Closes on promotion: #1779.
  2. Soften the TODO.md sentence to the static evidence only (adoption in Update codegen files #58, stub calls by pin, clean audit) and leave the Stage 2 item as is. Effect: smaller change, finding 2 filed as pre-existing follow-up.
  3. Drop the "no pilot is owed" clause entirely and merge as is.

Context

Handoff: #2165 (track auto-1779). Branch: feature/auto-1779. No pull request is blocked yet. Also outside this change, several Stage 1 boxes (for example ESPHome-Config, HomeAssistant-Config, Vantage-Config) are unticked though those repos already carry the stub.

Activity

  1. added
    decisionA question waiting on the maintainer, alone or beside whatever else the issue carries
    on Sep 30, 2026
  2. ptr727 commented on Sep 30, 2026

    @ptr727
    OwnerAuthor

    Answered by the maintainer on 2026-09-30: option 1. Cite the 2026-09-23 merge-bot run on a Dependabot PR into develop in the TODO.md sentence, and reword the Stage 2 "remaining repos" item so it no longer waits on the pilots closing. Applied on feature/auto-1779 under handoff #2165.

  3. removed
    decisionA question waiting on the maintainer, alone or beside whatever else the issue carries
    on Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions