Skip to content

Point the Charset-Unknown Message at Where a Tier Is Classified #2171

Description

@ptr727

Problem

The prose gate's charset-unknown finding message in .github/actions/prose-gate/prose_lint.py charset_findings ends "is in no tier - classify it in GOVERNANCE.md". GOVERNANCE.md "Character Set" holds no tier list, only a pointer. The tiers live in the comment-and-doc-style skill's "Character set" section and in the gate's TIER1, TIER2, and TIER3 tables. A reader who follows the message opens a file with nowhere to classify the character.

Found by the local strict review on the #2100 lane (handoff #2145). The message predates that change.

Fix

Point the message at where a classification actually goes, meaning the skill's "Character set" section and the gate's tier tables, and update any test that asserts the message text.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    pre-existingReview finding classed pre-existing per local-strict-review Disposing of FindingsproseA defect in rule or procedure text

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions