Skip to content

State the Guard's In-Order Heredoc Reading Condition as the Code Applies It #2200

Description

@ptr727

Problem

The #2112 fix on branch feature/auto-2112 (handoff #2123) describes the in-order heredoc reading as built "where every body closes" in three places: the module docstring and the _heredoc_readings docstring in host-setup/agent-safety/claude/gh-write-guard.py, and the rule's paragraph in host-setup/agent-safety/README.md. The code requires closure only through the last data body, so it builds more readings than the text says. That errs in the safe direction, but the prose does not describe the code.

Done looks like

All three places state the condition the code applies, closure through the last data body, and no other text claims the stricter condition.

Found by the third local strict review pass of the #2112 fix, and filed as a follow-up per decision #2126.

Activity

  1. added
    bugSomething isn't working
    agentsAgents instructions
    on Oct 1, 2026
  2. ptr727 commented on Oct 8, 2026

    @ptr727
    OwnerAuthor

    Kept per #2517, approved by the maintainer: a docstring stating a stricter condition than the code applies is a cheap real defect to fix, not a hardening case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agentsAgents instructionsbugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions