Repository navigation
Decide How the VS Code Tasks Snippet Covers a Listed Subdirectory's Type Check (#2157) #2212
Description
Question
How should catalog/snippets/configs/vscode-tasks-python.json's header cover a subdirectory listed in CI's python-directories input, now that #2157's fix drops the src path argument from the mypy swaps?
The unattended lane for #2157 (handoff #2211) dropped src from both swaps and pinned the Scripts-profile swap to uvx mypy@latest / uvx pyright@latest, as CI runs it. It also dropped "Adapt the target paths to the repo's package layout.", which #2157's Done allows. The local strict review then found that line also covered a case CI still has. A listed subdirectory with no checker config of its own falls back to the root's config, and CI runs the checker from the root against that directory's own project (uv run --project <dir> <checker> <dir>).
Two rounds of edits each drew a new finding on the replacement line, which exhausted the review budget:
- Round 1 restored a narrower line naming the directory as the target. The review found it omitted the subdirectory's project environment, so following it literally runs the checker in the root's environment.
- Round 2 replaced it with a pointer: "A subdirectory listed in CI's
python-directoriesinput adapts "Python Types" to the commandvalidate-task.yml's "Type check Python step" runs for that directory." The review found the pointer namesvalidate-task.ymlas if it were in the reader's tree, where downstream repos reach it from the hub at the SHA their caller workflow pins.
Options
- Recommended: qualify the pointer. It would read "...the command the hub's
validate-task.yml"Type check Python step", at the commit this repository's caller workflow pins, runs for that directory." This keeps the coverage the first review asked for and answers the open finding. It is a one-line edit on the parked branch, which then takes one more review pass and goes to a pull request. - Drop the subdirectory line entirely, which is Drop the Path Argument From the VS Code Tasks Snippet's Mypy Swaps #2157's literal Done. The header gets smaller and the parked branch loses one line. A listed subdirectory that relies on the root's config then gets no local guidance, which is the gap the first review raised. That finding would be declined as out of Drop the Path Argument From the VS Code Tasks Snippet's Mypy Swaps #2157's scope, or filed on its own.
- Describe the command inline instead, for example "runs
uv run --project <dir> mypy <dir>(orpyright <dir>) from the root, as CI does". The text stays self-contained. It does restate CI's mechanism in a comment, though, and that drew a new finding in each round, and the pip form (--python-executable/--pythonpath) still needs its own wording.
Blocks
- Handoff Session Handoff [auto-2157]: Drop the Path Argument From the VS Code Tasks Snippet's Mypy Swaps per #2157 #2211, track
auto-2157, whose work is on branchfeature/auto-2157(pushed, no pull request opened yet). - No open pull request. The develop pull request for Drop the Path Argument From the VS Code Tasks Snippet's Mypy Swaps #2157 opens once this is answered.
Activity
ptr727 commentedon Oct 1, 2026
Answered by the maintainer: option 1, qualify the pointer so it names the hub's
validate-task.yml"Type check Python step" at the commit this repository's caller workflow pins, then one more review pass and open the develop pull request.Name the Hub's Pinned Validate Step in the Subdirectory Pointer
Drop the Path Argument From the VS Code Tasks Snippet's Mypy Swaps (#…