Skip to content

Decide How the VS Code Tasks Snippet Covers a Listed Subdirectory's Type Check (#2157) #2212

Closed

Description

@ptr727

Question

How should catalog/snippets/configs/vscode-tasks-python.json's header cover a subdirectory listed in CI's python-directories input, now that #2157's fix drops the src path argument from the mypy swaps?

The unattended lane for #2157 (handoff #2211) dropped src from both swaps and pinned the Scripts-profile swap to uvx mypy@latest / uvx pyright@latest, as CI runs it. It also dropped "Adapt the target paths to the repo's package layout.", which #2157's Done allows. The local strict review then found that line also covered a case CI still has. A listed subdirectory with no checker config of its own falls back to the root's config, and CI runs the checker from the root against that directory's own project (uv run --project <dir> <checker> <dir>).

Two rounds of edits each drew a new finding on the replacement line, which exhausted the review budget:

  • Round 1 restored a narrower line naming the directory as the target. The review found it omitted the subdirectory's project environment, so following it literally runs the checker in the root's environment.
  • Round 2 replaced it with a pointer: "A subdirectory listed in CI's python-directories input adapts "Python Types" to the command validate-task.yml's "Type check Python step" runs for that directory." The review found the pointer names validate-task.yml as if it were in the reader's tree, where downstream repos reach it from the hub at the SHA their caller workflow pins.

Options

  1. Recommended: qualify the pointer. It would read "...the command the hub's validate-task.yml "Type check Python step", at the commit this repository's caller workflow pins, runs for that directory." This keeps the coverage the first review asked for and answers the open finding. It is a one-line edit on the parked branch, which then takes one more review pass and goes to a pull request.
  2. Drop the subdirectory line entirely, which is Drop the Path Argument From the VS Code Tasks Snippet's Mypy Swaps #2157's literal Done. The header gets smaller and the parked branch loses one line. A listed subdirectory that relies on the root's config then gets no local guidance, which is the gap the first review raised. That finding would be declined as out of Drop the Path Argument From the VS Code Tasks Snippet's Mypy Swaps #2157's scope, or filed on its own.
  3. Describe the command inline instead, for example "runs uv run --project <dir> mypy <dir> (or pyright <dir>) from the root, as CI does". The text stays self-contained. It does restate CI's mechanism in a comment, though, and that drew a new finding in each round, and the pip form (--python-executable / --pythonpath) still needs its own wording.

Blocks

Activity

  1. added
    decisionA question waiting on the maintainer, alone or beside whatever else the issue carries
    on Oct 1, 2026
  2. ptr727 commented on Oct 1, 2026

    @ptr727
    OwnerAuthor

    Answered by the maintainer: option 1, qualify the pointer so it names the hub's validate-task.yml "Type check Python step" at the commit this repository's caller workflow pins, then one more review pass and open the develop pull request.

  3. removed
    decisionA question waiting on the maintainer, alone or beside whatever else the issue carries
    on Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions