Skip to content

pr_review.py Does Not Carry a File Table Forward to a Later Round That States No Coverage #2282

Closed

Description

@ptr727

Problem

pr_review.py status reports coverage=unstated (exit 30, COVERAGE_IS_UNSTATED) on a pull request whose changed-file set is identical across two Copilot rounds.

The shape:

  • Round 1 is a ccr-overview-v2 review on head A. Its file table names exactly the N changed files, so status read coverage=table there.
  • A fix lands on the base branch, which moves the head to B. The changed-file set is still the same N files, with the same paths.
  • Round 2 is a ccr-overview-v2 review on head B with "Review effort: Lite", "Findings: None", and no file table.

status then prints NO FILE TABLE STANDS IN: no round covering the head carries a file table of its own. That holds although its own message says a round stating nothing "carries the newest round that states some forward, bounded on the change set", and the change set did not change.

Seen on ptr727/HomeAutomation-Config#705 (a develop -> main promotion), rounds 1 and 2.

Expected

A file table from an earlier round carries forward to a later round that states nothing, under the same change-set bound that already applies to a stated coverage line. Otherwise the coverage item can never close on a promotion pull request that took a fix between rounds.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions