Skip to content

Tolerate a Per-Field workflowRun Error in pr_review.py's Check Query #2338

Closed

Description

@ptr727

Problem

scripts/pr_review.py's Q_FULL reads checkSuite{ workflowRun{ workflow{ databaseId } } } to key superseded check runs by workflow (#2327). A token without Actions read access, such as a fine-grained token or a restricted GITHUB_TOKEN on a private repository, may get a per-field GraphQL error on workflowRun. gh_graphql exits on any errors entry, and gh api graphql itself exits non-zero when the response carries errors, so the whole digest would fail rather than fall back to the app slug.

This was not reproduced. An OAuth token with the repo scope reads the field without error.

Done When

Either a constructed reproduction shows the field never errors for the tokens the fleet uses, or gh_graphql tolerates an error whose path ends in workflowRun by treating that field as null, so the dedupe falls back to the app slug. Every other error still aborts the digest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions