Skip to content

Share One Recursive-Tree Change-Set Reader Between pr_review.py and audit.py #2789

Open

Description

@ptr727

Problem

Two hub tools now read a change set past the REST compare's 300-file cap the same way, each with its own copy of the reader. Both read a recursive tree for the merge base and for the other side, keep blob and submodule entries, diff them by path and object id, and refuse a truncated tree.

A fix to one copy, such as how a truncated tree or a submodule entry is read, does not reach the other.

Expected

One recursive-tree reader and one tree diff that both tools use, or a recorded reason they stay separate (for example that scripts/pr_review.py must stay a single self-contained file). Found by the local strict-review pass on the change for #2767, which left spec/audit.py alone because it is a file that change does not touch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions