Skip to content

Add a Catalog Snippet for the Release-With-Smoke Caller and Drop Its Placeholder Pins #2854

Closed

Description

@ptr727

Problem

The release-with-smoke caller shape is still a placeholder with no catalog snippet.

  • docs/reusable-workflows.md:300: "The release-with-smoke shape below keeps the placeholder @<hub-main-commit-sha> # <release-tag> until it has a catalog snippet of its own."
  • docs/reusable-workflows.md:352 and :361 are that stub, pinning validate-task.yml and build-release-task.yml to @<hub-main-commit-sha> # <release-tag>. The same placeholder appears at :420, :456, :489, and :498.
  • docs/reusable-workflows.md:159: "the release-with-smoke shape reaches the hub's build-release-task.yml by pin, so a snippet of its own is now writable, and this item stays open until one lands."
  • catalog/snippets/workflows/ holds test-pull-request.yml (the no-build shape, validate-task.yml only), publish-release.yml, merge-bot-pull-request.yml, and run-periodic-codegen-pull-request.yml, and nothing for a pull-request caller that also smoke-builds through build-release-task.yml.

Impact

An adopter of the smoke shape copies a stub whose pins are unusable and must find a released SHA and tag by hand, with no snippet Dependabot keeps current. The doc itself tracks this as an open item.

Suggested fix

Add a catalog snippet for the release-with-smoke test-pull-request.yml with a released pin, link it from docs/reusable-workflows.md:300, replace the placeholder in the stub with a pointer to it, and tick the item at :159.

Found while: adopting validate-task.yml in ptr727/homeassistant-purpleair

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    proseA defect in rule or procedure text

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions