You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fail Closed on an --admin a Run-Time Word Spells in the Write Guard #3006
Found by the local review of the lane closing #2957. Develop's guard shares it. It was found by reading _check_bypass_flags.
An --admin a Run-Time Word Spells Is Not Failed Closed
The push side fails closed on a run-time word among a push's words. The --admin check reads only the literal flag, so a word the shell rewrites into it passes:
gh pr merge 5 "$(printf %s --admin)"
A=--admin; gh pr merge 5 $A
Possible Direction
Fail closed on a run-time word among the arguments of gh pr merge, the way _rewritten_git_words does for a push or a commit, with the workaround of writing every word out.
Activity
Read Clustered and Cut-Short Push Options, Branch Patterns, List Expa…
Read Abbreviated, Clustered, and Negated Options in the Write Guard (#…