Skip to content

Session Handoff [auto-1892]: Log the Docker Task's Build-Base Leg In to Docker Hub for #1892 #3123

Closed

Description

@ptr727

Next steps, in priority order

  1. Fix The Docker Task's Build-Base Leg Has No Docker Hub Login, So It Cannot Push a Base Image #1892. In .github/workflows/build-docker-task.yml, give the docker-build-base job the same "Require Docker Hub credentials" and "Login to Docker Hub" steps the build-docker job carries, ahead of the "Run caller docker-build-base hook step", gated the way that job gates them, so a hook asked to push holds credentials. Then pass the hook the branch and smoke values the core already decides multi-arch from, the shape the issue's suggested fix names, and state those inputs wherever the docker-build-base hook contract is documented (docs/reusable-workflows.md "The Docker Family", and any WORKFLOW.md or catalog text describing the hook's inputs). Done looks like: the base leg logs in before its hook on a pushing run, the hook receives branch and smoke, the documented hook contract matches the job, the full local gate set and test suite green, and a pull request into develop carrying Closes on promotion: #1892, driven per drive-pr to merge.

External blockers

None known at pick time. A real Docker Hub push cannot be exercised from a local session, so verification is the workflow lint, the repo gate, and any existing workflow-contract tests rather than a live push.

Internal dependencies

None. The downstream repository that found this keeps its own build-base job until this ships, and dropping that job is that repository's own follow-up, not this lane's.

State

Picked from the open backlog by an unattended picker. No branch, worktree, or pull request exists for this lane yet. Re-derive: the current docker-build-base and build-docker jobs in build-docker-task.yml (the credential check and login steps, their if: gates, and the secrets the workflow declares), how build-release-task.yml forwards docker_build_base and the Docker Hub secrets, and every surface that documents the hook's inputs.

The parked decision queue

0 parked decisions on this lane.

What the last round did

Nothing yet. This is the lane's first link, created by the picker.

What not to repeat

Nothing recorded yet.

New learnings

None yet.

Activity

  1. added
    handoffA link in the session handoff chain, one open issue per track
    on Oct 16, 2026
  2. ptr727 commented on Oct 16, 2026

    @ptr727
    OwnerAuthor

    Lane closed out, run scope develop.

    Merged: #3124 into develop as ddaeefb. It fixes #1892, which closes on promotion through the Closes on promotion: #1892 line in that pull request's body.

    What changed:

    • build-docker-task.yml's docker-build-base job now runs the same Docker Hub credential check and login as build-docker, before the caller's hook runs.
    • The hook also receives branch and platforms. platforms is the platform list the core resolves once, now in workflow-level env.
    • docs/reusable-workflows.md "The Docker Family" states this hook contract.

    This lane's next steps named smoke rather than platforms. The local review pass found that smoke would make each hook re-derive a selection the file says is decided once. A composite action also reads that boolean as a string, so a hook copying the core's expression would never pick multi-arch. The issue offered the resolved platforms as an alternative, so the fix took that one.

    Review:

    • Two local strict-review passes were recorded. The first raised 3 findings, all fixed. The second raised none.
    • Copilot raised one thread, that a reusable workflow's top-level env cannot read inputs. It was declined with actionlint evidence and resolved.
    • CodeRabbit, run on request, made no actionable comments. All 13 checks passed.

    Filed along the way: nothing. No lesson issue.

    Left for others: NxWitness can drop its own build-base job once this is promoted and released. That is NxWitness's own follow-up, per this lane's body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    handoffA link in the session handoff chain, one open issue per track

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions