Skip to content

Test the Docker Task Workflow's Credential Check, Login, and Hook Inputs #3148

Closed

Description

@ptr727

Context

Raised by Copilot as a P2 finding on the develop -> main promotion #3146, against #3124, which gave build-docker-task.yml's docker-build-base job the Docker Hub credential check and login, and passed branch and platforms to the caller's hook. The finding asks for regression coverage of both. The gap is older than #3124: no test under tests/ names build-docker-task.yml on main or on develop, so the build-docker job's own credential check and login carry no test either.

Gap

A later edit could drop the login from either job, reorder it after the hook, or drop a hook input, and only a live run with a push would show it.

Possible Direction

A structural test in the shape tests/test_release_guards.py uses for other workflows: parse the workflow, and assert that each job pushing to Docker Hub runs the credential check and the login before any step that pushes, and that the hook step passes push, ref, branch, and platforms.

Activity

  1. added
    github_actionsPull requests that update GitHub Actions code
    pre-existingReview finding classed pre-existing per local-strict-review Disposing of Findings
    on Oct 16, 2026
  2. added a commit that references this issue on Oct 16, 2026
    f7a74a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    github_actionsPull requests that update GitHub Actions codepre-existingReview finding classed pre-existing per local-strict-review Disposing of Findings

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions