Skip to content

Decide Whether a Pin-Only Dependabot Bump Counts as Covered on a Promotion #3225

Closed

Description

@ptr727

Question

Should a Dependabot pull request that only bumps a pinned action count as covered under the promotion case of pr-review-conduct Merge Gate item 2?

Why it comes up

The promotion case lets a develop -> main promotion that exits 45 satisfy coverage, where every change it carries had full coverage on its own feature -> develop pull request. A Dependabot pull request is merged into develop with no Copilot round of its own, so any promotion carrying one fails that case, and the coverage call goes back to the maintainer. It also moves the promotion's head after a go-ahead was given, so the go-ahead is asked twice.

A constructed shape: a promotion carries two reviewed feature pull requests and one Dependabot pull request changing a single line, uses: example/action@<old-sha> # v1.0.0 to uses: example/action@<new-sha> # v1.1.0. Checks pass on the promotion head. status exits 45, and the promotion case does not apply.

Options

  1. Keep it the maintainer's call each time (recommended). A Dependabot pull request is bot-authored and untrusted under "Trust Boundaries and Hardening Effort". The cost is one prompt per promotion that carries one.
  2. Count a pin-only Dependabot bump as covered. Where the pull request's author is Dependabot, its diff changes only uses: pins and their version comments, and its checks passed, the promotion case treats its files as fully read. This removes the re-ask, but it widens a merge gate on bot-authored content, and pr_review.py and the rule text would both need the change.

Activity

  1. added
    decisionA question waiting on the maintainer, alone or beside whatever else the issue carries
    on Oct 19, 2026
  2. ptr727 commented on Oct 19, 2026

    @ptr727
    OwnerAuthor

    Maintainer decision, 2026-10-19: keep it the maintainer's call each time (option 1). A Dependabot pull request stays bot-authored and untrusted, and a promotion carrying one goes back to the maintainer for its coverage, which costs one prompt. No rule or script change.

  3. removed
    decisionA question waiting on the maintainer, alone or beside whatever else the issue carries
    on Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions