Skip to content

Audit Self-Test Aborts on Windows at the Invalid-Byte Filename Probe #3338

Closed

Description

@ptr727

Defect

python3 spec/audit.py --selftest aborts on Windows with CalledProcessError from git add -A (exit 128) in the hub_tracked invalid-byte filename probe in _selftest_cases, because the probe's non-UTF-8 name is created but git cannot add it there. The Windows unit test job surfaced it when a new test ran the self-test as a subprocess (found on the pull request for the git location helper). The probe catches OSError on creating the file but not a failing git add.

Expected

The probe skips on a host where git cannot add the name, as it already does where the file cannot be created.

Activity

  1. added
    bugSomething isn't working
    pre-existingReview finding classed pre-existing per local-strict-review Disposing of Findings
    scriptA defect in hub tooling
    on Oct 22, 2026
  2. added a commit that references this issue on Oct 22, 2026
    39afd75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingpre-existingReview finding classed pre-existing per local-strict-review Disposing of FindingsscriptA defect in hub tooling

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions