Skip to content

Exempt the BuildKit check= Parser Directive in the Prose Gate #3372

Closed

Description

@ptr727

The prose gate's TOOL_DIRECTIVE pattern in .github/actions/prose-gate/prose_lint.py lists the Dockerfile parser directives syntax= and escape= but not check=, the BuildKit build-check directive. A Dockerfile opening on a check= line therefore draws comment-case, and in diff mode comment-added, although the line is an instruction to BuildKit and has to be lowercase.

Reproduce with a constructed file:

# check=skip=CopyIgnoredFile

FROM scratch
python3 .github/actions/prose-gate/prose_lint.py <dir holding that Dockerfile>

It reports Dockerfile:1: comment-case: comment sentence opens in lowercase. Capitalizing the line is not a fix, since BuildKit then stops reading it as a directive.

Done means check= sits beside syntax= and escape= in TOOL_DIRECTIVE, with a test case for it. Found while clearing a downstream repository's whole-tree prose findings.

Activity

  1. added
    bugSomething isn't working
    proseA defect in rule or procedure text
    on Oct 22, 2026
  2. ptr727 commented on Oct 23, 2026

    @ptr727
    OwnerAuthor

    Closed under the maintainer's decision (ptr727, 2026-10-23) on #3391, item 3: the prose and documentation backlog frozen by #1311 in September is closed rather than worked one issue at a time, keeping open only the issues where a document states something the shipped code or workflow does not do. This issue was read as wording, structure, restatement, or a gap in guidance rather than a falsified claim. Reopen with the sentence and the behavior it misstates if that reading is wrong.

  3. ptr727 commented on Oct 23, 2026

    @ptr727
    OwnerAuthor

    Reopened: this is a prose gate code defect, a false positive the gate raises on text that breaks no rule, so it is a bug in a gate rather than a wording issue and the #3391 item 3 close sweep should not have taken it.

  4. reopened this on Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingproseA defect in rule or procedure text

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions