Skip to content

Fix the COVERAGE_IS_PARTIAL Status Text on the Carry Paths in pr_review.py #3424

Closed

Description

@ptr727

The status=COVERAGE_IS_PARTIAL line in report_verdict says the review covering the head states it read fewer files than the pull request changed. On the carry paths (an earlier partial beside a head stating nothing, or a head reading unknown) the bracketed reason says the opposite, so the line contradicts itself. Constructed case: earlier round reviewed=1 changed=3, head round reviewed=4 changed=3. Found by the local strict review of #3423.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions