Skip to content

Session Handoff [auto-3610]: #3610 Count Copilot Findings Under the Unresolved Bullet and File Table #3641

Closed

Description

@ptr727

Next steps, in priority order

Re-read the issue and the code rather than trusting this summary.

  1. Fix Count the Findings Under Copilot's "Review Findings Remain Unresolved" Bullet in pr_review.py #3610. In the Copilot ccr-overview-v2 reader (scripts/pr_review_copilot.py, with its digest in scripts/pr_review_digest.py), count each finding that the nested "Review findings remain unresolved:" list or the file table's Findings column names. Where the headline ("Approval recommended", "No open issues", no_active_issues) and those lists disagree, the lists win. Done looks like this: the constructed body in Count the Findings Under Copilot's "Review Findings Remain Unresolved" Bullet in pr_review.py #3610 counts 2 findings rather than 0, wait does not report that round clean, and a regression fixture plus unit test in tests/test_pr_review_copilot.py cover it. Run the whole test suite, and tests/test_pr_review_size.py among it. Drive the pull request into develop, with Closes on promotion: #3610 in its body.

External blockers

  • None known at pick time.

Internal dependencies

  • Module size ceilings in tests/test_pr_review_size.py bind the change. pr_review_copilot.py has room under its ceiling. pr_review_checks.py is close to its own, so put the change outside it, or split along module boundaries rather than raising a ceiling.

State

Re-derive with git worktree list, git log origin/main..origin/develop, and gh pr list.

  • No branch or worktree exists yet for this lane.
  • Open pull requests at pick time: none.

The parked decision queue

Zero open decision issues in this repository at pick time, read live.

What the last round did

  • This handoff was created by the unattended picker from the open backlog. No round has worked it yet.

What not to repeat

  • Nothing yet.

New learnings

  • None yet.

Activity

  1. added
    handoffA link in the session handoff chain, one open issue per track
    on Oct 30, 2026
  2. ptr727 commented on Oct 30, 2026

    @ptr727
    OwnerAuthor

    Outcome

    #3642 merged into develop as squash commit 8beff32, under the unattended run's develop scope. It fixes #3610, which closes when the promotion that carries 8beff32 merges, through the PR's Closes on promotion: #3610 line.

    • The Copilot reader now counts the findings a ccr-overview-v2 round names in its nested "Review findings remain unresolved:" list and in the file table's Findings column. They go in a new Reading.listed field. unthreaded includes them, so FINDINGS WITH NO THREAD prints.
    • Reading.open and overview=T/M keep the count the round states.
    • A clean round whose list or table names a finding no longer prints CLEAN VERDICT HEADLINE. A flagging round in that shape still exits 50, and its lines now name the headline beside the list or table.
    • No exit code changed.

    Local strict review ran over every push. Its findings were fixed in the branch, and the last pass, over fc8eb49, found none. Copilot's six threads from its round on an earlier head were each answered with the fixing SHA and resolved. Checks passed 13/13.

    Cleanup exited 0. It deleted the remote branch, the worktree, and the local branch, and confirmed each.

    Nothing else was filed along the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    handoffA link in the session handoff chain, one open issue per track

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions