Repository navigation
Let pr_review.py merge Read an Acknowledgment Record for Answered Earlier-Round Findings #3718
Description
Problem
pr_review.py merge refuses whenever any of these is on record from an earlier review round, even after the driver has given it an outcome: a suppressed or previously-missed Copilot finding, a CodeRabbit outside-diff finding, or a part under REVIEWER OUTPUT NOTED. Code cannot read the answer, so drive-pr and unattended-handoff route such a pull request to the maintainer for a hand merge. That is the path merge exists to remove. It also catches an acknowledged head round once a fix push moves the head. That round's unplaced parts then count as noted output.
Proposal
An acknowledgment record the driver posts, modelled on the existing shape_hold acknowledgment (comment --fingerprint). It lists each earlier-round finding or noted part by a stable key, each with its outcome. merge reads it and clears the counts the record covers. Anything it does not cover still refuses. Code then checks that a disposition was recorded for each item, while whether that disposition is right stays the driver's per pr-review-conduct.
Notes
scripts/pr_merge.pyandscripts/pr_review_digest.pysit close to their size ceilings, so this likely needs a module of its own.- Decided on the merge PR: keep
mergestrict until this lands.
Activity
Merge a Gate-Met Feature Pull Request Through pr_review.py and Own th…
ptr727 commentedon Nov 1, 2026
Released (2026-11-02): worktree and branch removed, so this claim holds no files. Its fix merged to develop in PR #3793.
Backlog burndown claim (round 2, group R2G4). Branch:
feature/burn-3718. Issues: #3718, #3724, #3777.Predicted file set:
scripts/pr_merge.py, a new acknowledgment module underscripts/,scripts/pr_review.py,scripts/pr_review_rounds.py,scripts/pr_review_digest.py,scripts/pr_review_copilot.py,scripts/README.mdtests/test_pr_merge.py,tests/test_pr_review.py,tests/test_pr_review_copilot.py,tests/test_pr_review_size.py.agents/skills/drive-pr/and its generated trees (.github/skills/drive-pr/,.claude-plugin/fleet-skills/skills/drive-pr/,.claude-plugin/fleet-skills/.source-digests/drive-pr).agents/skills/pr-review-conduct/and its generated trees (.github/skills/pr-review-conduct/,.claude-plugin/fleet-skills/skills/pr-review-conduct/,.claude-plugin/fleet-skills/.source-digests/pr-review-conduct)Answer Unthreaded Findings With an Acknowledgment Record pr_review.py…
ptr727 commentedon Nov 2, 2026
Released (2026-11-02): worktree and branch removed, so this claim holds no files. Its fix merged to develop in PR #3798.
Backlog burndown claim (round 2, promotion fix 2). Branch:
feature/burn-3797-fix2. Fixes the #3797 finding thathas_prosecounts a body holding only an inline-code span as prose, socomment --ackand--fingerprintaccept a body with no prose outside code.Predicted file set:
scripts/pr_review_copilot.py,tests/test_pr_review_copilot.pyRead Prose From an Inline Token's Text Children Outside Code (#3798)