Repository navigation
Name the Build Jobs That Do Not Opt Out of the Smoke Skip in D2.2 - #1533
Merged
Merged
Conversation
WORKFLOW.md D2.2 said github-release carries validate-release in needs: and does not opt out, but its if: carries !failure() && !cancelled(), so a skipped validate-release would not skip it. The jobs that do not opt out are dotnet-publish, build-nuget, and build-pypi, whose if: carries no status-check function, so a job-level skip would skip their smoke builds. That is the real reason the check exits inside the step. The sentence before it also named if: always() as the only opt-out, which D7.4 in the same section contradicts and build-docker's own guard disproves. It now states only the direction that holds: a dependent whose if: carries no status-check function gets the implicit success() and skips with it. The generated workflow-ci-contract include carries the same text. Settles the last open item of #1522, and item 1 of #1200. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe D2.2 documentation now describes implicit ChangesWorkflow contract documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The workflow documentation and metadata accurately describe the affected smoke-build jobs and their skip behavior. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation change is consistent with the workflow implementation and the distributed skill/reference copies are updated accordingly.
Pull request overview
Updates the workflow behavioral contract documentation to correctly name which release-task build jobs would be implicitly skipped if validate-release were skipped at the job level during smoke builds, aligning the contract text with the actual job if: conditions used in the release workflow.
Changes:
- Rewords
WORKFLOW.mdD2.2 to describe the “implicitsuccess()” behavior and name the impacted dependent jobs (dotnet-publish,build-nuget,build-pypi). - Propagates the same D2.2 wording into the carried
workflow-ci-contractreferences (authored source + generated distributions). - Updates canonical-review tracking artifacts (unit digests / stamps) to reflect the new reviewed content.
File summaries
| File | Description |
|---|---|
| WORKFLOW.md | Updates D2.2 wording to name the dependent jobs that would skip when a needs: entry is skipped and the dependent has no status-check function in if:. |
| reports/canonical-review.json | Refreshes canonical-review digests/stamps for the affected units. |
| .agents/skills/workflow-ci-contract/references/d-guarantees.md | Updates the authored skill reference copy of the D-guarantees include content. |
| .github/skills/workflow-ci-contract/references/d-guarantees.md | Regenerated GitHub Copilot skill distribution copy reflecting the updated D2.2 text. |
| .claude-plugin/fleet-skills/skills/workflow-ci-contract/references/d-guarantees.md | Regenerated Claude plugin skill distribution copy reflecting the updated D2.2 text. |
| .claude-plugin/fleet-skills/.source-digests/workflow-ci-contract | Updates the distribution digest for the workflow-ci-contract skill bundle. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Sep 11, 2026
ptr727
added a commit
that referenced
this pull request
Sep 11, 2026
) Promotes `develop` to `main`, carrying one merged pull request. Closes #1522 ## What this promotes - [#1533](#1533) corrects `WORKFLOW.md` D2.2's explanation of why `validate-release` exits inside its step on a smoke build rather than skipping at job level. It named `github-release` as a dependent that does not opt out of a skipped `needs:` entry, where `github-release`'s `if:` carries `!failure() && !cancelled()` and so runs past a skipped gate. D2.2 now names `dotnet-publish`, `build-nuget`, and `build-pypi`, whose `if:` carries no status-check function, so the implicit `success()` would skip their smoke builds. It also drops the sentence naming `if: always()` as the only opt-out, which D7.4 and `build-docker`'s own guard contradict, and states only the direction that holds. The `workflow-ci-contract` Skill's generated include carries the same text. It settles the last open item of #1522, item 1 of #1200, and item 28 of tracker #1369. ## Adopter impact Documentation only. No workflow, action, or script changes, so no fleet repository's build or publish behavior moves. ## Left open deliberately - [#1200](#1200): only its first item is settled here. - Whole-unit review of section 4 raised further statements this change did not write, each filed rather than fixed: #1523, #1524, #1527, #1531, and #1369 item 55 for section 4, and #1360 for `docs/reusable-workflows.md` "Permissions". ## Verification - Four whole-unit review rounds over `WORKFLOW.md` section 4 and its Skill include, recorded in `reports/canonical-review.json`, the last finding nothing in D2.2, and a local strict-review pass over the whole diff. The wording went past the two-round budget with the maintainer's explicit go-ahead, since each "skips unless" form drew the same finding. - Copilot reviewed #1533 at full coverage, 6 of 6 files, with no findings. - Prose gate, repo gate, spec validation, generated-skill check, and the Docker linters are green. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01QNQoguANRoFqeCJL7Kczc8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settles the last open item of #1522, and item 1 of #1200 and item 28 of tracker #1369, which report the same defect.
What changes
WORKFLOW.mdD2.2 explains whyvalidate-releaseexits inside its step on a smoke build rather than skipping at job level. It namedgithub-releaseas a dependent that does not opt out of a skippedneeds:entry.github-release'sif:carries!failure() && !cancelled(), so a skippedvalidate-releasewould not skip it. The dependents that do not opt out aredotnet-publish,build-nuget, andbuild-pypi, whoseif:carries no status-check function, so a job-level skip would skip their smoke builds.Whole-unit review of the first wording found that the sentence before it named
if: always()as the only opt-out, which D7.4 in the same section contradicts andbuild-docker's own guard disproves. Each "skips unless" wording that followed drew the same finding, since an explicitsuccess()carries a status-check function and replaces the implicit one, yet still skips on a skipped need. With the maintainer's go-ahead past the two-round budget, D2.2 now states only the direction that holds: a dependent whoseif:carries no status-check function gets the implicitsuccess()and skips with it.The
workflow-ci-contractSkill's generated include of section 4 carries the same text.Left open deliberately
Whole-unit review of section 4 also raised statements this change did not write. Most were already filed, and the three that were not are now recorded:
build-<target>pattern does not namedotnet-publish: WORKFLOW.md Sections 3, 4 and 6 Carry Statements the Tree Contradicts #1523.enable_*values: newly filed on WORKFLOW.md Sections 3, 4 and 6 Carry Statements the Tree Contradicts #1523.id-token: writeexample: WORKFLOW.md Sections 3 and 4 Carry Further Statements the Tree Contradicts #1524.github.ref_nameban on a top-level publisher: WORKFLOW.md Sections 4 and 6 Carry Further Statements the Tree Contradicts, Found Settling #1522 #1527.WORKFLOW.md > 4. Behavioral Contract: Expected Outcomes#1369 item 55.docs/reusable-workflows.md"Permissions" tells a release-upload task to declare its scope in the callee job, whichgithub-releasedeliberately does not: newly filed on Tracker:docs/reusable-workflows.md#1360.Verification
WORKFLOW.mdsection 4 and its Skill include, the last finding nothing in D2.2, recorded inreports/canonical-review.json, and a local strict-review pass over the whole diff.eol,eol-coverage), spec validation, generated-skill check, and the Docker linters are green.🤖 Generated with Claude Code
https://claude.ai/code/session_01QNQoguANRoFqeCJL7Kczc8
Summary by CodeRabbit