Scope VerifyReferenceAotCompatibility to an AOT Publish in dotnet-codestyle

.agents/skills/dotnet-codestyle/SKILL.md

@@ -214,7 +214,7 @@ parameterized tests. A test project on `xunit.v3` 4.0.0 or later is MTP-based, a
 
 ## Project configuration
 
-.NET 10.0 target, AOT-compatible (`IsAotCompatible=true`, `VerifyReferenceAotCompatibility=true`),
+.NET 10.0 target, AOT-compatible (`IsAotCompatible=true`, with `VerifyReferenceAotCompatibility=true` only under the `PublishAot` condition),
 SourceLink, embedded untracked sources, `InternalsVisibleTo` for test/benchmark access. See
 `references/project-config.md` for the full property list.
 

.agents/skills/dotnet-codestyle/references/project-config.md

@@ -1,8 +1,14 @@
 # .NET Project Configuration
 
 1. **Target framework**: .NET 10.0 (`<TargetFramework>net10.0</TargetFramework>`).
-2. **AOT compatibility**: `<IsAotCompatible>true</IsAotCompatible>`,
-   `<VerifyReferenceAotCompatibility>true</VerifyReferenceAotCompatibility>`.
+2. **AOT compatibility**: `<IsAotCompatible>true</IsAotCompatible>` unconditionally, and
+   `<VerifyReferenceAotCompatibility>true</VerifyReferenceAotCompatibility>` only in a
+   `<PropertyGroup Condition="'$(PublishAot)' == 'true'">`, placed in the `.csproj` after it sets
+   `PublishAot` or in `Directory.Build.targets`, never in `Directory.Build.props`, which is imported
+   before the project body and so never sees a `PublishAot` the `.csproj` sets. Reference
+   verification reports `IL3058` for every dependency not built AOT-compatible, and
+   `TreatWarningsAsErrors` turns that into a failed build on ordinary dependencies such as
+   `System.CommandLine` and the Serilog sinks, so it runs only where an AOT publish needs it.
 3. **Assembly information**: use semantic versioning, include SourceLink
    (`<PublishRepositoryUrl>true</PublishRepositoryUrl>`), embed untracked sources
    (`<EmbedUntrackedSources>true</EmbedUntrackedSources>`).

.claude-plugin/fleet-skills/.source-digests/dotnet-codestyle

@@ -1 +1 @@
-770653a908016ec0
+6afeadd6c65bfd8a

.claude-plugin/fleet-skills/skills/dotnet-codestyle/SKILL.md

@@ -214,7 +214,7 @@ parameterized tests. A test project on `xunit.v3` 4.0.0 or later is MTP-based, a
 
 ## Project configuration
 
-.NET 10.0 target, AOT-compatible (`IsAotCompatible=true`, `VerifyReferenceAotCompatibility=true`),
+.NET 10.0 target, AOT-compatible (`IsAotCompatible=true`, with `VerifyReferenceAotCompatibility=true` only under the `PublishAot` condition),
 SourceLink, embedded untracked sources, `InternalsVisibleTo` for test/benchmark access. See
 `references/project-config.md` for the full property list.
 

.claude-plugin/fleet-skills/skills/dotnet-codestyle/references/project-config.md

@@ -1,8 +1,14 @@
 # .NET Project Configuration
 
 1. **Target framework**: .NET 10.0 (`<TargetFramework>net10.0</TargetFramework>`).
-2. **AOT compatibility**: `<IsAotCompatible>true</IsAotCompatible>`,
-   `<VerifyReferenceAotCompatibility>true</VerifyReferenceAotCompatibility>`.
+2. **AOT compatibility**: `<IsAotCompatible>true</IsAotCompatible>` unconditionally, and
+   `<VerifyReferenceAotCompatibility>true</VerifyReferenceAotCompatibility>` only in a
+   `<PropertyGroup Condition="'$(PublishAot)' == 'true'">`, placed in the `.csproj` after it sets
+   `PublishAot` or in `Directory.Build.targets`, never in `Directory.Build.props`, which is imported
+   before the project body and so never sees a `PublishAot` the `.csproj` sets. Reference
+   verification reports `IL3058` for every dependency not built AOT-compatible, and
+   `TreatWarningsAsErrors` turns that into a failed build on ordinary dependencies such as
+   `System.CommandLine` and the Serilog sinks, so it runs only where an AOT publish needs it.
 3. **Assembly information**: use semantic versioning, include SourceLink
    (`<PublishRepositoryUrl>true</PublishRepositoryUrl>`), embed untracked sources
    (`<EmbedUntrackedSources>true</EmbedUntrackedSources>`).

.github/skills/dotnet-codestyle/SKILL.md

@@ -214,7 +214,7 @@ parameterized tests. A test project on `xunit.v3` 4.0.0 or later is MTP-based, a
 
 ## Project configuration
 
-.NET 10.0 target, AOT-compatible (`IsAotCompatible=true`, `VerifyReferenceAotCompatibility=true`),
+.NET 10.0 target, AOT-compatible (`IsAotCompatible=true`, with `VerifyReferenceAotCompatibility=true` only under the `PublishAot` condition),
 SourceLink, embedded untracked sources, `InternalsVisibleTo` for test/benchmark access. See
 `references/project-config.md` for the full property list.
 

.github/skills/dotnet-codestyle/references/project-config.md

@@ -1,8 +1,14 @@
 # .NET Project Configuration
 
 1. **Target framework**: .NET 10.0 (`<TargetFramework>net10.0</TargetFramework>`).
-2. **AOT compatibility**: `<IsAotCompatible>true</IsAotCompatible>`,
-   `<VerifyReferenceAotCompatibility>true</VerifyReferenceAotCompatibility>`.
+2. **AOT compatibility**: `<IsAotCompatible>true</IsAotCompatible>` unconditionally, and
+   `<VerifyReferenceAotCompatibility>true</VerifyReferenceAotCompatibility>` only in a
+   `<PropertyGroup Condition="'$(PublishAot)' == 'true'">`, placed in the `.csproj` after it sets
+   `PublishAot` or in `Directory.Build.targets`, never in `Directory.Build.props`, which is imported
+   before the project body and so never sees a `PublishAot` the `.csproj` sets. Reference
+   verification reports `IL3058` for every dependency not built AOT-compatible, and
+   `TreatWarningsAsErrors` turns that into a failed build on ordinary dependencies such as
+   `System.CommandLine` and the Serilog sinks, so it runs only where an AOT publish needs it.
 3. **Assembly information**: use semantic versioning, include SourceLink
    (`<PublishRepositoryUrl>true</PublishRepositoryUrl>`), embed untracked sources
    (`<EmbedUntrackedSources>true</EmbedUntrackedSources>`).