Skip to content

Compare Directories by File Identity in tool_shadow_path #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptr727 merged 1 commit into from
Sep 28, 2026
Merged

Compare Directories by File Identity in tool_shadow_path #1969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion host-setup/linux/install-tools.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,9 +914,12 @@ tool_shadow_path() {
# A trailing slash names the same directory, so strip it before comparing or building a path.
# "/" itself is the one entry with none to strip.
[[ $dir == / ]] || dir="${dir%/}"
[[ $dir == "$BIN_DIR" ]] && return 0
is_absolute=false
[[ $dir == /* ]] && is_absolute=true
[[ $dir == "$BIN_DIR" ]] && return 0
# A doubled slash or a dot segment matches $BIN_DIR by identity, not by literal spelling.
# Absolute only, so a relative entry can never short-circuit the walk past a real shadow.
[[ $is_absolute == true && $dir -ef $BIN_DIR ]] && return 0
# A relative PATH entry (".", "./bin") makes this relative to the caller's current directory, not a real shadow.
# What this returns gets removed by tool_unshadow, so only an absolute path is ever trusted as one.
candidate="${dir:-.}/$name"
Expand Down
Loading