Repository navigation
Record KiCadLibrary's Standup in the Registry and Rollout Trackers - #2303
Merged
Merged
Conversation
RESYNC.md section 3 and STANDUP.md section 1A now name the LF conversion as a pull request of its own that lands first wherever a repository's .editorconfig still defaults to CRLF, since every carried file is LF and fails the old default. docs/eol-lf-rollout.md says a squash-only develop keeps the renormalization isolated only when the conversion pull request carries nothing else, and to pin text-shaped vendor files -text before renormalizing. It ticks KiCadLibrary's box. KiCadLibrary's registry entry declares the python type with the root as its Python directory and CODECOV_TOKEN as a required secret, and drops two driftNotes its standup made false. Refs #2290 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rst Rule A -text pin alone keeps a CRLF vendor file CRLF and fails the new LF default, so the rollout doc now pairs each pin with an .editorconfig unset section, writes globs for both letter cases, and names the renormalization as what normalizes the files. The LF-first rule in RESYNC.md and STANDUP.md skips an operational repository recording lineEndings crlf and lets the conversion carry its own .editorconfig and .gitattributes. KiCadLibrary's registry entry keeps a corrected note that main trails develop until its promotion, and WORKFLOW.md says the build-release-asset upload runs on a non-smoke run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…espace The rollout doc told a conversion to leave .gitattributes alone, which described the old * -text file, under which a renormalization converts nothing. It now takes the hub's * text=auto eol=lf, and What Changed records that move. The vendor .editorconfig section also sets trim_trailing_whitespace false, so an editor does not rewrite a pinned file on save, and the merge-time registry step returns to the end of its own paragraph. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The RESYNC.md, STANDUP.md, and Per-Repo Conversion wording for #2290 drew new findings in every review round, so it returns to its develop text and #2290 keeps the findings for a change of its own. This pull request keeps KiCadLibrary's registry entry, its rollout checkbox, and the WORKFLOW.md non-smoke upload wording. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
KiCadLibrary now declares the python type, so its hooks row takes the pre-commit framework and doc gates, and the doc-gate-only rule names an eda repository with no Python rather than every eda repository. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2303 +/- ##
========================================
Coverage 58.22% 58.22%
========================================
Files 16 16
Lines 7821 7821
========================================
Hits 4554 4554
Misses 3267 3267
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All reviewed changes have no unresolved blocking issues.
Review effort: Lite
Findings: None
What changed in this PR
Records KiCadLibrary’s registry, rollout, and workflow documentation updates, including generated skill references.
Changes:
- Adds Python and coverage metadata to the registry.
- Updates LF and pre-commit rollout trackers.
- Clarifies release-asset upload behavior.
- Regenerates workflow guidance and its source digest.
| File | Summary |
|---|---|
WORKFLOW.md |
Clarifies non-smoke release-asset uploads. |
registry/repos.json |
Adds KiCadLibrary metadata and drift notes. |
docs/pre-commit-hooks-rollout.md |
Records KiCadLibrary’s hook rollout. |
docs/eol-lf-rollout.md |
Marks LF conversion complete. |
.github/skills/workflow-ci-contract/references/architecture.md |
Updates generated workflow guidance. |
.claude-plugin/fleet-skills/skills/workflow-ci-contract/references/architecture.md |
Updates generated workflow guidance. |
.claude-plugin/fleet-skills/.source-digests/workflow-ci-contract |
Updates the generated source digest. |
.agents/skills/workflow-ci-contract/references/architecture.md |
Updates canonical workflow guidance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ptr727
added a commit
that referenced
this pull request
Oct 3, 2026
…try (#2304) ## Summary Promotes `develop` to `main` with one pull request, already reviewed and merged into `develop`: - [#2303](#2303) records KiCadLibrary's standup. - **Registry entry:** it now declares the `python` type, the root as its Python directory, and `CODECOV_TOKEN` as a required secret, with corrected driftNotes. - **Rollout trackers:** KiCadLibrary is ticked in the LF rollout, and its hooks row takes the `pre-commit` framework. - **`WORKFLOW.md`:** says the `build-release-asset` upload runs on a non-smoke run. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These are the hub follow-ups from standing up KiCadLibrary, whose workflows, settings, resync, and README pull requests are merged on its
develop.registry/repos.json: KiCadLibrary's entry gets three additions.pythontype, with the root as its Python directory, matching thepython-directories: .its pull request gate and publisher now pass.CODECOV_TOKENas a required secret, since a Python repository with tests uploads coverage.maintrailsdevelopuntil the standup promotes it.WORKFLOW.md"Two Layers": thebuild-release-assetsentence says the task uploads the files on a non-smoke run, so it no longer reads as an upload on smoke too. The generated skill references are regenerated.docs/eol-lf-rollout.md: KiCadLibrary's box is ticked for ptr727/KiCadLibrary#57.docs/pre-commit-hooks-rollout.md: KiCadLibrary's row takes thepre-commitframework with the doc gates, and the doc-gate-only rule names anedarepository with no Python.The fix for #2290, the LF-first procedure, was drafted on this branch and withdrawn, because three review rounds kept finding new problems in the new procedure prose. Its findings are recorded on #2290 for a change of its own.
Verification
All of these pass:
spec/validate.pyscripts/build_dist.py --checkpython3 -m unittest discover -s testsprose_lint.pyspec/audit.py --branch develop KiCadLibraryraises no Python, Python-directory, or coverage finding. It reports only the missing secrets, a maintainer action. The local strict review's last pass found one pre-existing stale row (Blog), filed as #2302.🤖 Generated with Claude Code