Repository navigation
Name the Character Set Pointer's Tier System as Character-Set - #3396
Merged
Merged
Conversation
The write guard kept allexport on after a later set +a or set +o allexport, so a plain assignment it no longer exported still read as exported and a git command after it was denied. Apply each set flag in order. The Character Set pointer called an enumeration that now holds emoji callout markers an ASCII tier system, so it names the character-set tier system. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Ending allexport at a set +a read the off switch regardless of control flow (a function never called, a subshell, a pipeline, a loop rerun), which allowed what develop denied. Restore the one-way reading, which fails closed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The terminology-only change is fully reviewed and has no unresolved findings.
No open issues 🎉
What changed in this PR
This pull request renames the governance reference from “ASCII tier system” to “character-set tier system” to reflect its broader scope.
Changes:
- Updates the Character Set terminology in
GOVERNANCE.md. - Preserves the canonical tier definitions in the documentation skill.
| File | Description |
|---|---|
GOVERNANCE.md |
Renames the referenced character-set tier system. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Not changed here: the write guard keeps
allexporton after aset +a. Modeling the off switch was tried and allowed what develop denies for a function never called, a subshell, a pipeline, and a loop rerun, so it was reverted and filed instead.Verification
prose_lint.py --diff origin/developis clean. The change is one phrase inGOVERNANCE.md, and no other file carries the phrase "ASCII tier system".🤖 Generated with Claude Code