Say When an Earlier Partial Round Exits 42 in pr_review Docs by ptr727 · Pull Request #3433 · ptr727/ProjectTemplate

ptr727 · 2026-10-24T19:06:02Z

Summary

After #3423, pr_review.py lets an earlier partial round outrank a head round reading UNKNOWN, printing coverage=PARTIAL and exiting 42. pr-review-conduct and scripts/README.md still said only a stated partial exits 42.

pr-review-conduct Merge Gate item 2 and scripts/README.md (the exit-code table and the coverage= paragraph) now say when the earlier-partial path gives exit 42.
The generated mirrors are regenerated.

Closes on promotion: #3425

Introduced findings

Fixed in 3900f40 and cceba3a. The first push listed introduced, .agents/skills/pr-review-conduct/SKILL.md:49-50, scripts/README.md:206, scripts/README.md:227: the earlier-partial condition read "no head round states full". That excluded a head with one full and one UNKNOWN round, which exits 42, and covered a head with no round at all, which exits 0 in status. The wording now names a head round reading UNKNOWN, and a head with non-refusal rounds none stating coverage. The last local pass checked every head state against coverage() and report_verdict() and found nothing.
Fixed in cceba3a, pre-existing but adjacent: "A round covering the head that states full coverage satisfies this item" now adds "where no other head round reads UNKNOWN or partial".

Pre-existing findings, not filed

pre-existing, scripts/README.md:227: seven sentences on this paragraph line run past 25 words. Develop's copy of the line has eight, and none of the seven was written by this change.
pre-existing, .agents/skills/pr-review-conduct/SKILL.md:54: the coverage=carried:table sentence runs to 28 words, word for word as on develop. The rewrap touched its line.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

coderabbitai · 2026-10-24T19:06:09Z

Important

🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

Source mode: Auto
Repository: ptr727/ProjectTemplate
Branch: exit-42-docs-unknown-head
File: .coderabbit.yaml
Commit: cceba3a
Layers: Repository YAML
Review profile: CHILL
Plan: Advanced
Run ID: c02869ab-7ae6-45fa-bb3a-76936764fd2f

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

ptr727 · 2026-10-24T19:06:25Z

A recorded local strict-review pass covers head dd5af9127b70789bc63d65879235f2104605e710, the content this pull request carries at that commit against develop, and it recorded 3 findings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

ptr727 · 2026-10-24T19:09:42Z

A recorded local strict-review pass covers head cceba3afe4f219c7ff0301d32985302b2681ec82, the content this pull request carries at that commit against develop, and it recorded 0 findings.

Copilot

🟡 Changes recommended

The new exit-42 condition in the skill and the README does not match coverage(), so an agent could treat a blocked head as passing.

3 open issues

What changed in this PR

This PR updates the documentation for pr_review.py. After #3423, an earlier partial round can make a head with an unclear coverage reading exit 42. The docs in pr-review-conduct and scripts/README.md still described only a stated partial as an exit 42. The change rewraps the Merge Gate paragraph and the exit-code table, then copies the skill into the generated mirrors.

Changes:

The pr-review-conduct Merge Gate item 2 paragraph now describes when the earlier-partial path gives exit 42.
The scripts/README.md exit-code table and coverage= paragraph use the same condition.
The generated skill mirrors and their source digest are updated to match the source.

File	Description
scripts/README.md	Updates the exit-42 table row and the `coverage=` paragraph to describe the earlier-partial case.
.github/skills/pr-review-conduct/SKILL.md	Generated mirror of the Merge Gate paragraph. It should follow the source once regenerated.
.claude-plugin/fleet-skills/skills/pr-review-conduct/SKILL.md	Generated plugin mirror of the same Merge Gate paragraph.
.claude-plugin/fleet-skills/.source-digests/pr-review-conduct	Updates the source digest to match the regenerated skill. It must change again once the source is corrected.
.agents/skills/pr-review-conduct/SKILL.md	Hand-authored source for the Merge Gate paragraph, where the condition is stated.

_{Review effort: Lite}

codecov · 2026-10-24T19:16:40Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@d3d75dc). Learn more about missing BASE report.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #3433   +/-   ##
==========================================
  Coverage           ?   80.76%           
==========================================
  Files              ?       23           
  Lines              ?     8839           
  Branches           ?        0           
==========================================
  Hits               ?     7139           
  Misses             ?     1700           
  Partials           ?        0

Flag	Coverage Δ
python-3.13	`80.76% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…xes to Main (#3434) ## Summary Promotes the pull requests merged into develop since release 2.0.1158. - [#3422](#3422): `drive-pr` and `backlog-burndown` have every draft of a pull request body go in a file named for its repository and branch. Two lanes sharing one `pr-body.md` had published each other's drafts. - [#3423](#3423): in `pr_review.py`, an earlier partial round outranks a head round reading `unknown`, printing `coverage=PARTIAL` and exiting 42. - [#3427](#3427): the prose gate takes run-block heredoc bodies from its patched Bash lexer's heredoc tokens and lexes each alone, so an apostrophe in a body no longer hides later comments. Inline Markdown comments are numbered with code spans masked. The gate's size ceiling moves from 1800 to 1840 lines, as the maintainer decided on that pull request. Two edge cases are deferred to #3429 and #3430, and a pre-existing one is filed as #3428. - [#3431](#3431): deletes `spec/carried_text.py` and reads carried Markdown regions through markdown-it-py in the new `spec/fidelity_text.py`. `carry.py`, `build_dist.py`, and `canonical_review.py` carry PEP 723 metadata, and every caller runs them as `uv run --no-project --script`. The full audit sweep is identical before and after. The `validate.py` remainder is #3426, and a pre-existing include-marker gap is #3432. - [#3433](#3433): `pr-review-conduct` and `scripts/README.md` say exactly when the earlier-partial path exits 42, following #3423. Closes #3412 Closes #3413 Closes #3414 Closes #3425 ## Constituent coverage Each change this promotion carries had coverage on its own pull request into develop, at its merged head: | Pull request | Merged head | Coverage | | --- | --- | --- | | [#3422](#3422) | `b645b429` | attested local pass, and a Copilot table naming exactly the changed files, `coverage=table` | | [#3423](#3423) | `3f893b65` | attested local pass, and a carried Copilot table, `coverage=carried:table` | | [#3427](#3427) | `2511b62b` | attested local pass, and a carried Copilot table, `coverage=carried:table` | | [#3431](#3431) | `92755285` | attested local pass, `coverage=local` | | [#3433](#3433) | `cceba3af` | attested local pass, `coverage=local` | 🤖 Generated with [Claude Code](https://claude.com/claude-code)

ptr727 and others added 3 commits October 24, 2026 12:00

Say an Unknown Head Beside an Earlier Partial Exits 42

8a9b992

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Split the Partial-Coverage Sentence in the pr_review README

0f324aa

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Exempt a Head Stating Full From the Earlier-Partial Exit

dd5af91

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI lite review requested due to automatic review settings October 24, 2026 19:06

Copilot started reviewing on behalf of ptr727 October 24, 2026 19:06

View session

ptr727 and others added 2 commits October 24, 2026 12:06

Name the Full-Plus-Unknown and No-Round Heads in the Exit-42 Wording

3900f40

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Exclude Refusal Rounds and Qualify Full Coverage in the Exit-42 Wording

cceba3a

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI reviewed Oct 24, 2026

View reviewed changes

Comment thread .agents/skills/pr-review-conduct/SKILL.md Resolved

Comment thread scripts/README.md Resolved

Comment thread scripts/README.md Resolved

ptr727 merged commit 4c77db2 into develop Oct 24, 2026
13 checks passed

ptr727 deleted the exit-42-docs-unknown-head branch October 24, 2026 19:41

ptr727 mentioned this pull request Oct 24, 2026

Promote the markdown-it Shared Reader, Heredoc Lexing, and Exit-42 Fixes to Main #3434

Merged

ptr727 mentioned this pull request Oct 24, 2026

Session Handoff [default]: Two Burndown Rounds Released as 2.0.1313 and 2.0.1319, Round 3 Next #2361

Open

Navigation Menu

Repository navigation

Say When an Earlier Partial Round Exits 42 in pr_review Docs - #3433

Say When an Earlier Partial Round Exits 42 in pr_review Docs#3433
ptr727 merged 5 commits into
developfrom
exit-42-docs-unknown-head

ptr727 commented Oct 24, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 24, 2026 •

edited

Loading

Uh oh!

ptr727 commented Oct 24, 2026

Uh oh!

ptr727 commented Oct 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Oct 24, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ptr727 commented Oct 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Introduced findings

Pre-existing findings, not filed

Uh oh!

coderabbitai Bot commented Oct 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ptr727 commented Oct 24, 2026

Uh oh!

ptr727 commented Oct 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Oct 24, 2026

Codecov Report

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ptr727 commented Oct 24, 2026 •

edited

Loading

coderabbitai Bot commented Oct 24, 2026 •

edited

Loading