[ptr727]

Summary

Replaces the line ceiling on .github/actions/prose-gate/prose_lint.py with a check aimed at what the ceiling stood for, per the maintainer's decision on #3441. The ceiling's own docstring said vocabulary and exemptions live in prose-gate.json, and a line count could not tell that defect from parser logic, so each lexer fix moved the ceiling or compacted unrelated code to fit.

TestVocabularyLivesInTheData in tests/test_prose_lint.py now fails where the script holds either of these:

• A string equal to a banned spelling, as prose_lint.british_spellings generates them, or to an entry of an exemption list. Stem and ending fragments and the US forms are not entries, since they are ordinary words a lexer may spell. Neither are service_accounts, names like root an identifier can use.
• A collection literal of more than five words, counted through nested literals and reported once at the outermost. A word is letters alone, with inner spaces, hyphens, and apostrophes allowed, so flags, paths, and environment variable names are not words. GIT_LOCATION therefore settles without an exemption by name. A mapping's key counts only beside a value holding words, so RULE_TABLE's dispatch keys do not.

Each shape has a case on a constructed script, and the real script holds none.

Verification

• Full unit suite, python -m unittest discover -s tests with tests/requirements.txt: 2947 tests, OK, 7 skipped.
• ruff format and check, mypy: clean. prose_lint.py --diff against the merge base, with and without --check sentence-length: clean.
• On a copy of the real script with "judgement", a six-word nested tuple, and a hub_hosted path appended, the check reports all three. Renaming GIT_LOCATION reports nothing, since its entries are not words.
• Three local adversarial passes, at the frontier tier. The first found stem fragments and US forms read as entries, nested literals uncounted, flags counted as words, and an overclaiming docstring, each fixed. The second found two cases that proved nothing, both fixed. The third found nothing.

Declined local findings

• Path and directive lists are not counted toward the cap (introduced). Paths and directive names are also the script's own logic, its argv and the file names it reads, so counting them false-fires the way counting flags did. An exact copy of an existing entry is still caught by equality.
• Counting stops at a frozenset(...) call (introduced). Counting through calls false-fires on RULE_TABLE, the gate's own dispatch idiom, whose hyphenated word keys sit over frozenset groups.

Pre-existing findings, not filed

• .github/actions/prose-gate/prose_lint.py TERMINATOR: an abbreviation list (e.g, i.e, vs, etc) sits inside a regex, a shape no literal check reads (pre-existing).
• A word list written as one string split at runtime, "a b c".split(), reads as one constant and is not counted (pre-existing, no instance in the script).

🤖 Generated with Claude Code

[ptr727]

A recorded local strict-review pass covers head 9d631289859dd57826c5f183e88a38564f0d58da, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: ptr727/ProjectTemplate
• Branch: prose-gate-vocab-check
• File: .coderabbit.yaml
• Commit: 9d63128
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: d186b3a6-421a-4b03-b4df-47d03724d5a2

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

🟢 Approval recommended

The reviewed changes have no unresolved findings, and all approval-readiness assessments support approval.

No open issues 🎉

What changed in this PR

This pull request replaces the brittle line-count ceiling for prose_lint.py with AST-based checks that keep vocabulary and exemption data in prose-gate.json.

Changes:

• Detects copied data-file entries and oversized word-based collection literals.
• Handles nested collections, mapping keys, flags, paths, directive names, and service-account names.
• Removes the obsolete production-script line-count assertion.

File	Description
tests/​test_prose_lint.py	Adds vocabulary-detection helpers and comprehensive tests, and removes the obsolete line ceiling test.

_{Review effort: Lite}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.98%. Comparing base (412ce42) to head (9d63128).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3474   +/-   ##
========================================
  Coverage    80.98%   80.98%           
========================================
  Files           25       25           
  Lines         8895     8895           
========================================
  Hits          7204     7204           
  Misses        1691     1691           

Flag	Coverage Δ
python-3.13	80.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.