Skip to content

Restore Meaning Lost in the GOVERNANCE and AGENTS Sentence Splits - #3579

Merged
ptr727 merged 2 commits into
developfrom
feature/3531-governance-agents-split-audit
Oct 28, 2026
Merged

ptr727 merged 2 commits into
developfrom
feature/3531-governance-agents-split-audit

Conversation

@ptr727

@ptr727 ptr727 commented Oct 28, 2026

Copy link
Copy Markdown
Owner

Summary

Audits every sentence that #3551 (GOVERNANCE.md, squash 444ec63e) and #3559 (AGENTS.md and .github/copilot-instructions.md, squash eb35070d) split or rewrote. Each new sentence was compared with its original. The splits listed below had lost or changed meaning, and each is repaired here. Every repaired sentence stays within the 25-word cap.

The agent-conduct and session-handoff include regions are regenerated from the new GOVERNANCE.md text. No other skill's region changes.

Repairs

Each line reads sweep text -> repaired text.

Reason left on only one half of a split

  • GOVERNANCE.md "Verification Discipline", canonical content: the manifest-owned tree, the byte-for-byte compare, and the drift on the next fidelity check stood as bare facts. -> "That is because the tree is manifest-owned, and the copy is compared...", then "It is also because a local edit there is drift...".
  • Same bullet: "It would otherwise reach a carrier..." -> "It is also because such a unit would otherwise reach a carrier...".
  • GOVERNANCE.md "Communicating with the User", blocked work: "The one line still waiting on the user is the easiest in it to skim past." -> "It is also because the one line still waiting on the user is the easiest in a summary to skim past."
  • Same section, parked queue: "Closing such an issue just to clear the queue discards..." -> "It is also because closing such an issue...".
  • GOVERNANCE.md "Workflow YAML Conventions", action pinning: "Dependabot still bumps SHA pins..." -> "It is also because Dependabot still bumps SHA pins...".
  • GOVERNANCE.md "Running the Linters Locally", pre-push hook: "Those describe the same content only sometimes." -> rejoined to its "That is because" sentence with ", and those describe...".
  • Same section, excludes: "The gate refuses one rather than reporting..." -> "Skipping them also matters because the gate refuses one...".

A "so" consequence left on only one half

  • GOVERNANCE.md "Hub-Hosted Tooling": "A tool taking its target as an argument runs anywhere..." -> "Likewise, a tool taking its target...".
  • GOVERNANCE.md "Running the Linters Locally", pre-push hook: "The prose layer above stays the agent-agnostic one..." -> "The prose layer above therefore stays...".

A condition no longer reaching every clause it covered

  • GOVERNANCE.md "Verification Discipline", locating checks: "Read that file whole where it exists..." -> "In that case, read that file whole...".
  • GOVERNANCE.md "Repository Details": "The fix is to sharpen the declared source..." read as the fix for any drift. -> "The fix there is to sharpen...".

A pronoun or "that" losing its antecedent

  • GOVERNANCE.md "Verification Discipline", canonical content: "It adds a bounded slice..." -> "That work also covers a bounded slice...".
  • AGENTS.md "Session Scope": "That section states the account whole..." now followed a different sentence. -> "That GOVERNANCE.md section states the account whole...".

An example list turned into a closed definition

  • GOVERNANCE.md "Character Set": "Its tiers are never legitimate, ..., and developer-typed Unicode." The skill has four tiers, and developer-typed Unicode stays regardless of tier. -> "That tier system covers what is never legitimate, ...", then "It also covers a fixed set of emoji callout markers and developer-typed Unicode."

A restriction widened

  • .github/copilot-instructions.md "Disproved Claims": "A reason not to check is strictly worse than proving the claim a second time." generalized to any reason. -> "That outcome is strictly worse...".

Verification

  • python3 scripts/prose_lint.py --check sentence-length on GOVERNANCE.md, AGENTS.md, and .github/copilot-instructions.md: exit 0 each.
  • uv run --no-project --script scripts/build_dist.py --check: current.
  • python3 scripts/prose_lint.py . --diff origin/develop and the whole-tree --check block from OPERATIONS.md "Local Verification": exit 0.
  • scripts/repo_gate.py, spec/validate.py, and canonical_review.py status: clean.
  • unittest discover -s tests: 3081 tests, OK (7 skipped).

Local Review

Two recorded local-strict-review passes at the frontier tier, each checking every hunk against its pre-sweep original. The first raised 2 introduced findings. The Character Set repair had an unclear "It" and a list with no noun, and the excludes repair had an "It" with no antecedent. Both are fixed in the second commit. The second pass raised none.

Refs #3531

🤖 Generated with Claude Code

ptr727 and others added 2 commits October 28, 2026 14:10
Audit of the sentence-length sweeps for GOVERNANCE.md and AGENTS.md /
copilot-instructions.md, comparing each split with its original. Each
repair puts back a reason left on one half of a split, a qualifier that
no longer reached every clause, a pronoun that lost its antecedent, or an
example list that had turned into a closed definition. Every repaired
sentence stays within the 25-word cap. The agent-conduct and
session-handoff include regions are regenerated from the new text.

Refs #3531

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Names the tier system and the skipped lines as the subjects of the two
repaired sentences, so neither leans on an "It" with no antecedent.

Refs #3531

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 28, 2026 21:14
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ptr727

ptr727 commented Oct 28, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 2f567f9ad306a41ab1341336cd83950bc58ab04d, the content this pull request carries at that commit against develop, and it recorded 0 findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified in the supplied evidence, so the documented guidance and synchronized skill distributions appear ready for approval.

No open issues 🎉

What changed in this PR

This pull request restores meaning lost during the 25-word sentence cleanup of the governance and agent-instruction documents, then synchronizes the affected generated skill distributions and source digests.

Changes:

  • Repairs causal links, conditions, antecedents, examples, and scope in GOVERNANCE.md, AGENTS.md, and .github/copilot-instructions.md.
  • Regenerates the affected agent-conduct and session-handoff skill distributions.
  • Updates the corresponding Claude skill source digests.
File Description
GOVERNANCE.md Restores meaning across governance, verification, workflow, and documentation guidance.
AGENTS.md Clarifies the GOVERNANCE.md section referenced by handoff rules.
.github/​skills/​session-handoff/​SKILL.md Updates the GitHub session-handoff skill distribution.
.github/​skills/​agent-conduct/​SKILL.md Updates the GitHub agent-conduct skill distribution.
.github/​copilot-instructions.md Restores the intended scope of the disproved-claims rule.
.claude-plugin/​fleet-skills/​skills/​session-handoff/​SKILL.md Updates the Claude session-handoff skill distribution.
.claude-plugin/​fleet-skills/​skills/​agent-conduct/​SKILL.md Updates the Claude agent-conduct skill distribution.
.claude-plugin/​fleet-skills/​.source-digests/​session-handoff Updates the session-handoff source digest.
.claude-plugin/​fleet-skills/​.source-digests/​agent-conduct Updates the agent-conduct source digest.
.agents/​skills/​session-handoff/​SKILL.md Updates the authored session-handoff guidance.
.agents/​skills/​agent-conduct/​SKILL.md Updates the authored agent-conduct guidance.

Review effort: Lite

@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.60%. Comparing base (b72f50f) to head (2f567f9).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3579   +/-   ##
========================================
  Coverage    81.60%   81.60%           
========================================
  Files           26       26           
  Lines         9070     9070           
========================================
  Hits          7402     7402           
  Misses        1668     1668           
Flag Coverage Δ
python-3.13 81.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727
ptr727 merged commit b82a4a0 into develop Oct 28, 2026
14 checks passed
@ptr727
ptr727 deleted the feature/3531-governance-agents-split-audit branch October 28, 2026 21:27
ptr727 added a commit that referenced this pull request Oct 28, 2026
…WORKFLOW Sentence Splits (#3580)

## Summary

Promotes `develop` to `main`, carrying the sentence-split audit of the
carried rule text:

- #3578: restores the antecedents, reasons, and condition scope that
earlier sentence-cap splits lost. It covers `WORKFLOW.md`, the
workflow-ci-contract references, and their generated copies.
- #3579: restores the meaning lost in the `GOVERNANCE.md`, `AGENTS.md`,
and `.github/copilot-instructions.md` sentence splits, and in the
agent-conduct and session-handoff skills with their generated copies.

Both pull requests continue #3531 and do not close it.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants