Repository navigation
Restore Meaning Lost in the GOVERNANCE and AGENTS Sentence Splits - #3579
Conversation
Audit of the sentence-length sweeps for GOVERNANCE.md and AGENTS.md / copilot-instructions.md, comparing each split with its original. Each repair puts back a reason left on one half of a split, a qualifier that no longer reached every clause, a pronoun that lost its antecedent, or an example list that had turned into a closed definition. Every repaired sentence stays within the 25-word cap. The agent-conduct and session-handoff include regions are regenerated from the new text. Refs #3531 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Names the tier system and the skipped lines as the subjects of the two repaired sentences, so neither leans on an "It" with no antecedent. Refs #3531 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
A recorded local strict-review pass covers head |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified in the supplied evidence, so the documented guidance and synchronized skill distributions appear ready for approval.
No open issues 🎉
What changed in this PR
This pull request restores meaning lost during the 25-word sentence cleanup of the governance and agent-instruction documents, then synchronizes the affected generated skill distributions and source digests.
Changes:
- Repairs causal links, conditions, antecedents, examples, and scope in
GOVERNANCE.md,AGENTS.md, and.github/copilot-instructions.md. - Regenerates the affected
agent-conductandsession-handoffskill distributions. - Updates the corresponding Claude skill source digests.
| File | Description |
|---|---|
GOVERNANCE.md |
Restores meaning across governance, verification, workflow, and documentation guidance. |
AGENTS.md |
Clarifies the GOVERNANCE.md section referenced by handoff rules. |
.github/skills/session-handoff/SKILL.md |
Updates the GitHub session-handoff skill distribution. |
.github/skills/agent-conduct/SKILL.md |
Updates the GitHub agent-conduct skill distribution. |
.github/copilot-instructions.md |
Restores the intended scope of the disproved-claims rule. |
.claude-plugin/fleet-skills/skills/session-handoff/SKILL.md |
Updates the Claude session-handoff skill distribution. |
.claude-plugin/fleet-skills/skills/agent-conduct/SKILL.md |
Updates the Claude agent-conduct skill distribution. |
.claude-plugin/fleet-skills/.source-digests/session-handoff |
Updates the session-handoff source digest. |
.claude-plugin/fleet-skills/.source-digests/agent-conduct |
Updates the agent-conduct source digest. |
.agents/skills/session-handoff/SKILL.md |
Updates the authored session-handoff guidance. |
.agents/skills/agent-conduct/SKILL.md |
Updates the authored agent-conduct guidance. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3579 +/- ##
========================================
Coverage 81.60% 81.60%
========================================
Files 26 26
Lines 9070 9070
========================================
Hits 7402 7402
Misses 1668 1668
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…WORKFLOW Sentence Splits (#3580) ## Summary Promotes `develop` to `main`, carrying the sentence-split audit of the carried rule text: - #3578: restores the antecedents, reasons, and condition scope that earlier sentence-cap splits lost. It covers `WORKFLOW.md`, the workflow-ci-contract references, and their generated copies. - #3579: restores the meaning lost in the `GOVERNANCE.md`, `AGENTS.md`, and `.github/copilot-instructions.md` sentence splits, and in the agent-conduct and session-handoff skills with their generated copies. Both pull requests continue #3531 and do not close it. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Summary
Audits every sentence that #3551 (
GOVERNANCE.md, squash444ec63e) and #3559 (AGENTS.mdand.github/copilot-instructions.md, squasheb35070d) split or rewrote. Each new sentence was compared with its original. The splits listed below had lost or changed meaning, and each is repaired here. Every repaired sentence stays within the 25-word cap.The
agent-conductandsession-handoffinclude regions are regenerated from the newGOVERNANCE.mdtext. No other skill's region changes.Repairs
Each line reads sweep text -> repaired text.
Reason left on only one half of a split
GOVERNANCE.md"Verification Discipline", canonical content: the manifest-owned tree, the byte-for-byte compare, and the drift on the next fidelity check stood as bare facts. -> "That is because the tree is manifest-owned, and the copy is compared...", then "It is also because a local edit there is drift...".GOVERNANCE.md"Communicating with the User", blocked work: "The one line still waiting on the user is the easiest in it to skim past." -> "It is also because the one line still waiting on the user is the easiest in a summary to skim past."GOVERNANCE.md"Workflow YAML Conventions", action pinning: "Dependabot still bumps SHA pins..." -> "It is also because Dependabot still bumps SHA pins...".GOVERNANCE.md"Running the Linters Locally", pre-push hook: "Those describe the same content only sometimes." -> rejoined to its "That is because" sentence with ", and those describe...".A "so" consequence left on only one half
GOVERNANCE.md"Hub-Hosted Tooling": "A tool taking its target as an argument runs anywhere..." -> "Likewise, a tool taking its target...".GOVERNANCE.md"Running the Linters Locally", pre-push hook: "The prose layer above stays the agent-agnostic one..." -> "The prose layer above therefore stays...".A condition no longer reaching every clause it covered
GOVERNANCE.md"Verification Discipline", locating checks: "Read that file whole where it exists..." -> "In that case, read that file whole...".GOVERNANCE.md"Repository Details": "The fix is to sharpen the declared source..." read as the fix for any drift. -> "The fix there is to sharpen...".A pronoun or "that" losing its antecedent
GOVERNANCE.md"Verification Discipline", canonical content: "It adds a bounded slice..." -> "That work also covers a bounded slice...".AGENTS.md"Session Scope": "That section states the account whole..." now followed a different sentence. -> "ThatGOVERNANCE.mdsection states the account whole...".An example list turned into a closed definition
GOVERNANCE.md"Character Set": "Its tiers are never legitimate, ..., and developer-typed Unicode." The skill has four tiers, and developer-typed Unicode stays regardless of tier. -> "That tier system covers what is never legitimate, ...", then "It also covers a fixed set of emoji callout markers and developer-typed Unicode."A restriction widened
.github/copilot-instructions.md"Disproved Claims": "A reason not to check is strictly worse than proving the claim a second time." generalized to any reason. -> "That outcome is strictly worse...".Verification
python3 scripts/prose_lint.py --check sentence-lengthonGOVERNANCE.md,AGENTS.md, and.github/copilot-instructions.md: exit 0 each.uv run --no-project --script scripts/build_dist.py --check: current.python3 scripts/prose_lint.py . --diff origin/developand the whole-tree--checkblock fromOPERATIONS.md"Local Verification": exit 0.scripts/repo_gate.py,spec/validate.py, andcanonical_review.py status: clean.unittest discover -s tests: 3081 tests, OK (7 skipped).Local Review
Two recorded
local-strict-reviewpasses at thefrontiertier, each checking every hunk against its pre-sweep original. The first raised 2introducedfindings. The Character Set repair had an unclear "It" and a list with no noun, and the excludes repair had an "It" with no antecedent. Both are fixed in the second commit. The second pass raised none.Refs #3531
🤖 Generated with Claude Code