Skip to content

Split the Over-Length Comment Sentences in pr_review and host_gate - #3606

Merged
ptr727 merged 4 commits into
developfrom
feature/3531-cmt-pr-review-host-gate
Oct 29, 2026
Merged

ptr727 merged 4 commits into
developfrom
feature/3531-cmt-pr-review-host-gate

Conversation

@ptr727

@ptr727 ptr727 commented Oct 29, 2026

Copy link
Copy Markdown
Owner

Part of #3531.

Splits the over-length sentences in the comments and docstrings of pr_review*.py, pr_cleanup.py, gh_graphql.py, host_gate.py, and their two test files. Comments and docstrings only, no code or asserted string changed. scripts/pr_review.py's pinned docstring phrases are unchanged.

Sentence-length count for the slice went from 186 to 0.

Tests: uv run --no-project --with pytest --with markdown-it-py python -m pytest tests/test_pr_review.py tests/test_host_gate.py tests/test_pr_review_size.py tests/test_pr_cleanup.py tests/test_gh_graphql.py passes (696 passed).

The pr_cleanup.py "A branch is finished when" sentence uses the wording scripts/README.md already carries.

Copies left for the comment sweep

None. The two scripts/README.md table cells that restate pieces of the status and wait exit codes are worded differently and already read zero.

Local strict review: two passes, the first raised drift items that the last commit restores, the second found none.

🤖 Generated with Claude Code

ptr727 and others added 2 commits October 29, 2026 07:34
Part of #3531.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Part of #3531.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@ptr727 ptr727 added the comments Permits the comment lines the pull request adds or edits, which the prose gate otherwise refuses label Oct 29, 2026
Copilot AI lite review requested due to automatic review settings October 29, 2026 14:42
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ptr727

ptr727 commented Oct 29, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 01bc85e582d36ac5527588d3addf578e33e622a4, the content this pull request carries at that commit against develop, and it recorded 17 findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Two active nit-level findings remain open: an unclear remedy clause in the probe() docstring in scripts/host_gate.py, and missing blank lines before separate rules in the help text in scripts/pr_review.py.

2 open issues
What changed in this PR

This PR splits over-length sentences in the comments and docstrings of the PR review scripts, the cleanup script, the GraphQL helper, and the host gate, along with two of their test files. It is part of a wider effort to bring the repository's sentence-length check to zero. It changes no code and no asserted string, so behavior stays the same. The author reports that the sentence-length count for this slice went from 186 to 0.

Changes:

  • Long sentences in comments and docstrings are split into shorter ones.
  • Some run-on lists of conditions and exit codes become bullet points.
  • The pr_cleanup.py branch-finished sentence is reworded to match the wording in scripts/README.md.
File Description
tests/​test_pr_review.py Rewraps long test docstrings and comments into shorter sentences. Assertions are unchanged.
tests/​test_host_gate.py Splits long docstring and comment sentences. Two schema-comparison comments are reworded.
scripts/​pr_review.py Splits the help text into shorter sentences and turns skip and exit-code conditions into bullets. Pinned docstring phrases are unchanged.
scripts/​pr_review_rounds.py Splits docstrings for the table matcher, thread matcher, and local-pass check. The local-pass check now lists its conditions.
scripts/​pr_review_copilot.py Splits one module docstring sentence and one entry-parsing docstring sentence.
scripts/​pr_review_checks.py Splits long sentences in the check normalization docstring.
scripts/​pr_cleanup.py Turns the refusal conditions into a list and splits the sweep's finished-branch definition.
scripts/​host_gate.py Splits long module, probe, merge, and overlay docstrings and comments. Some lists become bullets.
scripts/​gh_graphql.py Splits the module docstring and the request and walker docstrings into shorter sentences.

Review effort: Lite

Comment thread scripts/host_gate.py Resolved
Comment thread scripts/pr_review.py Resolved
@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.60%. Comparing base (0d4e6f1) to head (69f7bb1).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3606   +/-   ##
========================================
  Coverage    81.60%   81.60%           
========================================
  Files           26       26           
  Lines         9070     9070           
========================================
  Hits          7402     7402           
  Misses        1668     1668           
Flag Coverage Δ
python-3.13 81.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ptr727 and others added 2 commits October 29, 2026 07:50
Part of #3531.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Part of #3531.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Oct 29, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 69f7bb18958d2ef4c3dcbb7dd52c975a23f7d313, the content this pull request carries at that commit against develop, and it recorded 2 findings.

@ptr727
ptr727 merged commit d084707 into develop Oct 29, 2026
13 checks passed
ptr727 added a commit that referenced this pull request Oct 29, 2026
…tence-length a Default Check (#3619)

Promotes the #3531 comment sweep and its default flip from `develop` to
`main`.

- [#3603](#3603) Moves the
dispatch-refresh note out of the Docker clause in
branching-and-release-model.
- [#3606](#3606) Splits
over-length comment sentences in pr_review and host_gate.
- [#3607](#3607) Splits
over-length comment sentences in the local and canonical review engines.
- [#3608](#3608) Splits
over-length comment sentences in build_dist, carry, handoff, and
skills_install.
- [#3609](#3609) Splits
over-length comment sentences in the prose and repo gates.
- [#3611](#3611) Splits
over-length comment sentences in the spec scripts and workflows.
- [#3612](#3612) Splits
over-length comment sentences in the host install scripts.
- [#3613](#3613) Splits
over-length comment sentences in the host menu, bootstrap, and setup
scripts.
- [#3615](#3615) Splits
over-length comment sentences in the agent-safety kit, repo config, and
snippets.
- [#3618](#3618) Makes
`sentence-length` a default prose gate check.

Closes #3531
Closes #3588

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@ptr727
ptr727 deleted the feature/3531-cmt-pr-review-host-gate branch October 29, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comments Permits the comment lines the pull request adds or edits, which the prose gate otherwise refuses

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants