[ptr727]

Summary

host-setup/linux/install-tools.sh's package_installed matched dpkg's whole ${Status} against install ok installed. A held package, whose status is hold ok installed, therefore read as missing and was planned for install again. setup-github.sh already read a hold as installed, so the two hub copies of the check disagreed.

• One definition. Both scripts now carry the same package_installed, which compares ${db:Status-Status} to installed. Each Linux script stays independently fetchable, per host-setup/README.md "Three Rules This Directory Follows", so the definition is an identical copy rather than a sourced file. A new test in tests/test_setup_github.py holds the two copies equal, and the README's list of duplicated helpers now names it.
• Held Docker conflicts. With a hold now counted, the Docker conflict removal would hand a held conflict to apt-get remove -y, which refuses it with exit 100, while a -s simulation passes. docker_install now reads ${db:Status-Want} first. Where any name on Docker's uninstall list is held, it warns with the apt-mark unhold remedy and returns before removing anything, so docker lands in the failed set. That covers every name on the list, docker-doc included, on purpose. A held runc or containerd beside an unheld docker.io would otherwise remove the distro engine and then fail the docker-ce install, leaving the host with no engine.

Verification

• python3 -m unittest tests.test_install_tools tests.test_setup_github: 78 tests pass, with 1 skipped. The new tests fail against the base branch's install-tools.sh.
• Run in a throwaway debian:13 container with less and runc installed and held. Both scripts read the held less as installed. apt_missing does not plan either held package. docker_install reports the held runc, returns 1, and leaves it installed. In the same container, apt-get remove -y on the held runc exits 100 and apt-get remove -s exits 0, which is why a dry run is not the evidence.
• docker_lint.py passes shellcheck, shfmt, editorconfig-checker, markdownlint, and cspell. The pre-commit hook passes ruff, mypy, and the prose gate.
• The local strict review ran three passes. The first raised a reuse finding, fixed by moving the equality test onto the existing function_body helper. The second found that leaving a held conflict installed while still removing the others could remove the engine, fixed by restoring refuse-before-removing. The third raised nothing.

Closes on promotion: #3511

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: ptr727/ProjectTemplate
• Branch: feature/auto-3511
• File: .coderabbit.yaml
• Commit: 43adbcf
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 5bffdc4f-06d0-49df-981f-336a0f07eabb

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[ptr727]

A recorded local strict-review pass covers head 43adbcff16df2def2ea9da188ba61e7894eaec8d, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[Copilot]

🟢 Approval recommended

No active review issues remain, and the changes include regression coverage for held-package detection, Docker conflict handling, and helper-definition parity.

No open issues 🎉

What changed in this PR

This pull request updates Linux host setup to recognize held Debian packages as installed and prevents Docker installation from removing held conflicting packages.

Changes:

• Aligns package_installed with dpkg’s normalized installed-status field in both Linux scripts.
• Refuses Docker conflict removal when any conflicting package is held, with an apt-mark unhold remedy.
• Adds regression tests for held packages, Docker conflicts, and helper-definition parity.

File	Summary	Review notes
tests/​test_setup_github.py	Tests held-package detection and parity between both Linux helper definitions.	—
tests/​test_install_tools.py	Tests held package handling and Docker conflict refusal.	Nit (P2; 1 vote): correct “a format names” to “the format names” in the new docstring.
host-setup/​README.md	Documents the duplicated installed-package helper.	Nit (P2; 1 vote): clarify that the helper is duplicated between the Linux scripts only.
host-setup/​linux/​setup-github.sh	Uses the normalized dpkg status field to detect installed packages.	—
host-setup/​linux/​install-tools.sh	Recognizes held packages and blocks removal of held Docker conflicts.	Nit (P2; 1 vote): document held-conflict refusal and the apt-mark unhold remedy in the operator-facing Docker setup documentation.

_{Review effort: Lite}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.70%. Comparing base (b38e084) to head (43adbcf).
⚠️ Report is 24 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3650      +/-   ##
===========================================
+ Coverage    81.60%   81.70%   +0.09%     
===========================================
  Files           26       26              
  Lines         9070     9119      +49     
===========================================
+ Hits          7402     7451      +49     
  Misses        1668     1668              

Flag	Coverage Δ
python-3.13	81.70% <ø> (+0.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.