[ptr727]

Why

Copilot's round on promotion #3736 found that pr_review.py merge reports a pull request read back CLOSED after the merge call as MERGE_NOT_CONFIRMED, exit 2, "may still land on the server". A closed pull request cannot merge later, so a driver following drive-pr step 4 was sent to read back a merge that cannot have happened.

What

• A read-back of CLOSED is status=REFUSED, exit 1, nothing merged, whatever gh answered. The scripts/README.md contract says so.
• It shares the branch an OPEN refusal already takes, so pr_merge.py stays under its size ceiling. The first push's separate branch tripped test_pr_review_size.py in CI. The line now names the state it read and what gh answered, or nothing where the call never finished.
• A test covers gh exit 0, exit 1, and a call that never finished. It fails on the previous code, which returned exit 2 for each.

The same round's other two findings are answered on #3736 rather than changed here:

• Retargeted base: ready() already re-checks the base on the read after the gate, at scripts/pr_merge.py in merge().
• Cleanup skipped on PEER_MERGED: scripts/README.md "pr_merge.py" and drive-pr step 4 state this as the contract.

Local review

Two local-strict-review passes ran at the frontier tier.

• The first raised 3 findings. A redundant base check I had added was dropped, together with its README claim. The closed read-back test's subtests now read only their own output.
• The second raised nothing.
• After the CI ceiling failure, the third raised 1: the shared branch named a gh refusal that had not happened. The fourth raised nothing.
• The full suite of 3249 tests passes locally.

🤖 Generated with Claude Code

[ptr727]

A recorded local strict-review pass covers head 4f0a42ce2a5ff6d31c61f4b4c7d1d8ac9c9e6306, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[coderabbitai]

Important

• Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: ptr727/ProjectTemplate
• Branch: feature/merge-promotion-findings
• File: .coderabbit.yaml
• Commit: 4c95c03
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 03e5f3e3-86d4-47e1-b9bd-8257e7f5538a

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[Copilot]

🟢 Approval recommended

No active review issues remain, with the refusal contract documented and regression coverage addressing both gh merge outcomes.

No open issues 🎉

What changed in this PR

Updates pr_review.py merge so a post-merge CLOSED pull request read-back is treated as a definitive refusal rather than an unconfirmed merge.

Changes:

• Returns status=REFUSED with exit code 1 for CLOSED read-backs.
• Documents the updated refusal and exit-code contract.
• Adds regression coverage for both successful and failed gh merge responses.

File	Summary
tests/​test_pr_merge.py	Verifies closed read-backs for both gh exit codes.
scripts/​README.md	Documents the closed read-back and refusal behavior.
scripts/​pr_merge.py	Classifies closed pull requests as confirmed refusals after the merge call.

_{Review effort: Lite}

[ptr727]

A recorded local strict-review pass covers head 4c95c037fbe208739cd882a4e015391073af3d18, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.31%. Comparing base (06e45c4) to head (4c95c03).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3737   +/-   ##
========================================
  Coverage    82.31%   82.31%           
========================================
  Files           28       28           
  Lines         9437     9438    +1     
========================================
+ Hits          7768     7769    +1     
  Misses        1669     1669           

Flag	Coverage Δ
python-3.13	82.31% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.