[ptr727]

Summary

A failed winget install or upgrade in host-setup/windows/install-tools.ps1 names the processes holding the tool's files only where something says files were in use. Before this change the only signals were the package's own installer log (<id>.*.log) and a short list of exit codes. A portable or zip package, astral-sh.uv among them, has no installer, so it writes no such log. winget's refusal to delete a running executable is reported under the generic 0x8A150052, so such an upgrade failed with no hint of what held the file.

• Get-InstallerFailureReason now also reads winget's own WinGet-<timestamp>.log for the failed call. That is the latest one created at or after the attempt that names the package id, which winget logs among its arguments, and only its <E> lines are kept. The list and show probes that run before the attempt are passed over.
• In winget's own log, an access denial naming a file (Access is denied.: "<path>") counts as files in use, as does Windows' "used by another process". A denial naming no file does not. The installer-log wording is unchanged, since an installer's "Access is denied" can be a permission failure no running process causes.
• Select-FailureEntry is the old in-function "last few entries, keep the in-use one" logic pulled out, so both logs share it.
• Write-InstallFailure prints a winget's own log says: block and the log's path beside the installer-log block.

This applies to every winget package rather than to uv alone. A package with an installer still reports through its installer log as before.

The comments label is on this pull request because the change corrects the header comments of both functions, which the new behavior would otherwise leave false.

Verification

• uv run --no-project --with pytest python -m pytest tests/test_install_tools.py -q: 23 passed, 18 skipped. The new cases cover a portable package's reason read from winget's log, a longer id that only starts with the package id not being read as its log, an installer log's denial alone and a winget denial naming no file not counting as in use, and the report naming holders from winget's log.
• The new Get-InstallerFailureReason run on a Windows 11 host against a real failed portable upgrade's DiagOutputDir selected the upgrade's own session log over the probes before it, set InUse to true, and returned the remove: Access is denied. entry.
• Ruff, mypy, and PSScriptAnalyzer with the repository settings are clean.

Findings from the local strict review

Five recorded passes ran, the last over 10a272ba with no findings. The two introduced findings this body listed after the opening push are both fixed in 8e5a0b6b:

• host-setup/windows/install-tools.ps1:601 (introduced): the Write-InstallFailure header said a Git upgrade that failed on a download "leaves no log", which winget's own session log made false. Fixed in 8e5a0b6b.
• host-setup/windows/install-tools.ps1:507 (introduced): the winget-log in-use pattern accepted "access is denied" on any <E> line. Fixed in 8e5a0b6b, which counts only a denial naming a file.

The fourth pass also raised a dead empty-entry guard in Select-FailureEntry, fixed in 10a272ba. It raised one more, a denial naming a file outside the tool's install tree, such as winget's temp download folder under an antivirus lock, counting as in use. That one is declined under GOVERNANCE.md "Trust Boundaries and Hardening Effort". Its only effect is a printed suggestion naming processes running from the tool's own install tree, which is neither silent nor destructive nor one an outsider can trigger. winget logging such a denial is also unverified.

🤖 Generated with Claude Code

[coderabbitai]

Important

• Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: ptr727/ProjectTemplate
• Branch: fix/winget-in-use-from-winget-log
• File: .coderabbit.yaml
• Commit: 10a272b
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 87260aa8-fbf2-4929-9a2a-92a85d49b8e2

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

CodeRabbit Verify

• Run CodeRabbit Verify to test the changes in this pull request.

[ptr727]

A recorded local strict-review pass covers head 51d2f6ea43d79c3183faa20a8c61e723e6921047, the content this pull request carries at that commit against develop, and it recorded 2 findings.

[Copilot]

🟡 Changes recommended

Active issues remain: the documentation is inaccurate about which logs may be absent, and broad access-denied matching can misclassify unrelated WinGet failures and trigger misleading process enumeration.

2 open issues

• Match access-denied errors only for file removal · New
• Clarify that only the installer log may be absent · New

What changed in this PR

This pull request improves failed winget install diagnostics by reading winget’s own session logs, allowing portable packages to report file-use failures and likely holding processes.

Changes:

• Reads matching WinGet-*.log files and extracts relevant error entries.
• Shares failure-entry selection between winget and installer logs.
• Distinguishes winget file-removal failures from installer permission errors.
• Expands test coverage for portable packages, log selection, denial handling, and failure reporting.

The pull request requires changes to narrow access-denied matching to file-removal diagnostics and correct the stale comment about download failures leaving no log. Package IDs containing hyphens also require corrected boundary matching.

File	Description
tests/​test_install_tools.py	Adds coverage for winget-log parsing, portable packages, log selection, denial handling, and failure reports.
host-setup/​windows/​install-tools.ps1	Adds winget session-log diagnostics, shared failure-entry selection, and holder reporting.

_{Review effort: Lite}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.30%. Comparing base (753c536) to head (10a272b).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3851   +/-   ##
========================================
  Coverage    83.30%   83.30%           
========================================
  Files           29       29           
  Lines         9937     9937           
========================================
  Hits          8278     8278           
  Misses        1659     1659           

Flag	Coverage Δ
python-3.13	83.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ptr727]

A recorded local strict-review pass covers head 10a272ba9c06ab6450a6f3982ad0289c58da2a8b, the content this pull request carries at that commit against develop, and it recorded 0 findings.