[ptr727]

Why

#3881 left two defects in scripts/pr_review_side.py, and #3885 adds two design items and a documentation gap. Each sits on the review-cutover track (#3877), and the pilot needs the first one fixed before any repository gives CodeRabbit or Qodo when: after-checks.

What

• An after-checks side reviewer is asked once CI settles (Ask an After-Checks Side Reviewer Once CI Settles, and Document the Exit 44 Holds #3885 item 1). side.ask read the head's checks once, after the Copilot poll. So where a Copilot round already covered the head, or landed first, a check still running gave PENDING and only a note. Nothing asked later, since the merge gate's run_wait passes may_request=False. Now a wait that polls for a Copilot round hands the ask the await_green partial, which polls the checks on the wait's own clock and is bounded by --timeout. Every other wait reads them once. That covers the checks-hold, unrecorded-request, quota and refusal stops, exit 49, and a held head, whose own poll already waits on the checks. A wait that polled re-reads the payload before its digest and exit code, so a check that went green during the side poll is not judged stuck from a stale read. A pull request merged or closed while its checks settled is asked nothing.
• Ask times compare as instants (Compare Side-Reviewer Ask Times With the Head's Commit Time in UTC #3887). side_asked_on_head compared a comment's UTC createdAt with the head's committedDate as text, and a GitTimestamp keeps the committer's offset. Both now go through pr_review_checks.utc_instant.
• Exit 44 names its DIRTY and unreadable holds (Ask an After-Checks Side Reviewer Once CI Settles, and Document the Exit 44 Holds #3885 item 2), in the wait usage text and scripts/README.md. The exit-0 text now also names the after-checks exception to "does not poll the checks".
• PAYLOAD_KEY is gone (Ask an After-Checks Side Reviewer Once CI Settles, and Document the Exit 44 Holds #3885 item 3). Callers read pr_review_payload.POLICY_KEY, and the test asserting the two agree is dropped.
• One post-and-confirm helper (Ask an After-Checks Side Reviewer Once CI Settles, and Document the Exit 44 Holds #3885 item 4). side.post_comment posts a conversation comment and says whether its URL and exact body confirm it. comment_on_pr and the side asks both call it.

scripts/pr_review.py sits at 2199 of its 2200-line ceiling after this change. The next change that adds logic there has to move some first, as #3880 plans.

Refs #3885, #3887, #3877. The closing keywords belong on the develop -> main promotion PR.

Verification

• The full suite, uv run --no-project --with-requirements tests/requirements.txt python -m unittest discover -s tests, ran 3539 tests with 11 skipped, all passing, at 6bd9a5c. The test_pr_review* suites pass at the head, 709 tests.
• The new TestSideAskTiming cases in tests/test_pr_review_policy.py were each run against the pre-change scripts or with their fix reverted, and each one failed. Those are the outlasting-CI ask, the poll hand-off per wait path, the merged-during-poll ask, the fresh digest read, and both UTC offsets.
• ruff format and check are clean. The pre-commit hook's mypy, prose and EOL gates pass.

Local-review findings, disposed

Three recorded local-strict-review passes at the frontier tier covered the branch. The third, at 08cb68a, raised nothing.

• introduced, fixed in bc8e6ae: the digest and exit code came from a payload read before the side poll, so a check that went green during it could read as NOT_PICKED_UP and exit 44.
• introduced, fixed in bc8e6ae: a held head handed the ask a poll, which could delay exit 46 by up to --timeout.
• introduced, fixed in bc8e6ae: a pull request merged while its checks settled could still be asked.
• introduced, fixed in bc8e6ae: the usage text and the README 0 row still said a covered head's exit 0 never polls the checks.
• introduced, fixed in 08cb68a: the usage text and README still said any polling wait awaits the checks after the held-head change.

🤖 Generated with Claude Code

[coderabbitai]

Important

• Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: ptr727/ProjectTemplate
• Branch: fix/side-ask-after-checks-and-utc
• File: .coderabbit.yaml
• Commit: ea11a9e
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: c9a37079-51e0-49a8-8e4f-8c8601811cc0

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[ptr727]

A recorded local strict-review pass covers head 08cb68a3f317a4e526b0897d9405a9454b6a48e2, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[Copilot]

🟡 Changes recommended

An active P2 finding remains because a sentence in scripts/pr_review_side.py is ungrammatical and obscures the meaning about preserving the committer’s offset.

1 open issue

• Restore the missing noun in the commit timestamp sentence · New

What changed in this PR

This pull request updates policy-driven side-review timing, UTC timestamp comparisons, comment confirmation, documentation, and related test coverage.

Changes:

• Polls checks after Copilot waits before requesting eligible side reviewers.
• Compares commit and comment timestamps as UTC instants.
• Centralizes comment posting and confirmation, removes the duplicate policy-key alias, and documents exit-44 conditions.
• Adds coverage for polling, closure, timestamp offsets, holds, and comment confirmation.
• Review findings include one unresolved polling issue and two documentation nits.

This pull request requires changes.

File	Summary
tests/​test_pr_review.py	Updates tests to use the canonical policy payload key.
tests/​test_pr_review_policy.py	Adds coverage for timing, polling, closure, UTC comparisons, holds, and comment confirmation.
scripts/​README.md	Documents after-checks polling and exit-44 conditions.
scripts/​pr_review.py	Wires side-review polling, fresh payload reads, and shared comment posting into the wait flow.
scripts/​pr_review_side.py	Implements check polling, UTC timestamp handling, and shared comment confirmation.
scripts/​pr_review_policy.py	Removes the duplicate payload-key alias.
scripts/​pr_review_payload.py	Clarifies ownership of the canonical policy-key constant.

_{Review effort: Lite}

[ptr727]

A recorded local strict-review pass covers head ea11a9e3af0141ab81283744249cd668f24a88e2, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.13%. Comparing base (b38e084) to head (ea11a9e).
⚠️ Report is 103 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3888      +/-   ##
===========================================
+ Coverage    81.60%   84.13%   +2.52%     
===========================================
  Files           26       32       +6     
  Lines         9070    10580    +1510     
===========================================
+ Hits          7402     8901    +1499     
- Misses        1668     1679      +11     

Flag	Coverage Δ
python-3.13	84.13% <100.00%> (+2.52%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.