You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Make the Download Tests Deterministic and Offline #452
UtilitiesTests/DownloadAsyncTests.cs:68 expects failure from https://thisdoesnotexist123456789.com/file.txt, which relies on that name never resolving.
UtilitiesTests/DownloadAsyncTests.cs:81 uses https://httpstat.us/200?sleep=5000 to exercise the timeout path.
Why it is worth changing
A third-party outage, a DNS policy on the runner, or a rate limit reds the gate for a reason unrelated to the change under test, and the 5-second sleep is paid on every run. The negative case is the weakest of the four, because a registered wildcard or a captive-portal resolver turns a name that does not resolve into one that does, and the assertion silently inverts.
The fix is a loopback HTTP server in the test, or an injectable HttpClient handler seam, so success, failure, timeout, and cancellation are all deterministic and offline. The seam is the larger of the two, since it is a public-API decision: ARCHITECTURE.md records Download as reusing a thread-safe Lazy<HttpClient>, so exposing a handler changes what consumers can depend on and belongs in that document in the same change.
Where it came from
Raised by the reviewer on #451 against UtilitiesTests/DownloadAsyncTests.cs:16 and UtilitiesTests/DownloadTests.cs:13. Declined there rather than fixed, because that change normalizes every text file from CRLF to LF and these two files are byte-identical to develop with the carriage returns stripped. Rewriting them inside that diff would bury a behavioral change in the churn that makes the rest of it mechanically verifiable.
Activity
Resync the Repository with the Hub and Normalize Line Endings to LF (#…
Fix the StringHistory Limits and Make the Download Tests Offline (#455)
Resync the Repository with the Hub and Normalize Line Endings to LF (#…
Fix the StringHistory Limits and Make the Download Tests Offline (#455)
Promote Develop to Main (#456)
Resync the Repository with the Hub and Normalize Line Endings to LF (#…
Fix the StringHistory Limits and Make the Download Tests Offline (#455)
Promote Develop to Main (#456)