Skip to content

fix: make Dependabot see the composite actions - #4

Merged
mdozhdev merged 2 commits into
mainfrom
fix/dependabot-composite-actions
Sep 17, 2026
Merged

mdozhdev merged 2 commits into
mainfrom
fix/dependabot-composite-actions

Conversation

@mdozhdev

@mdozhdev mdozhdev commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #3, which flagged this as "verify on the first run". The first run has now happened, and the answer is that it did not work.

What went wrong

#3 configured Dependabot with:

directories:
  - /
  - /.github/actions/**

The glob was accepted — it appears verbatim in the job definition ("directories":["/.","/.github/actions/**"]) — but it matched nothing. Both runs after the v1.0.0 merge checked exactly two dependencies:

Checking if actions/checkout 7.0.1 needs updating        -> No update needed
Checking if zizmorcore/zizmor-action 0.6.3 needs updating -> No update needed

Both live in .github/workflows/. None of the five docker/* pins were looked at. That is not ambiguous: docker/build-push-action is pinned at v6 and v7.3.0 exists, so an available update would have been reported had Dependabot seen the file.

Why it matters

The pins are the point of this repository. A SHA pin without a working bump bot is a frozen version that nobody is told to move — including a frozen vulnerable one. The cooldown and the bot only do their job as a pair.

The fix

List each action directory explicitly. The github-actions ecosystem resolves action.yml in a named directory; it does not expand ** into one.

Verifying

Dependabot re-runs when this config changes on the default branch, so the next run's log after merge should show docker/build-push-action, docker/login-action, docker/metadata-action, docker/setup-buildx-action and docker/setup-qemu-action being checked — and should open bump PRs for the majors they are behind. If it still misses them, Renovate is the fallback.

🤖 Generated with Claude Code

The `/.github/actions/**` glob was accepted by Dependabot but matched
nothing. Its first run after v1.0.0 checked only actions/checkout and
zizmorcore/zizmor-action, both of which live in .github/workflows/ — the
five docker/* pins in the composite actions were never looked at, and
docker/build-push-action is pinned at v6 while v7.3.0 exists, so an
update would certainly have been reported had they been seen.

Left unfixed, the pins this repo exists to hold would never be told to
move: a SHA pin without a working bump bot is a frozen version, which is
the failure the cooldown and the bot were meant to prevent together.

Listing each action directory explicitly is what the github-actions
ecosystem actually resolves.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@mdozhdev
mdozhdev force-pushed the fix/dependabot-composite-actions branch from ef1eaab to e7c144a Compare September 7, 2026 08:10
@mdozhdev mdozhdev mentioned this pull request Sep 11, 2026
@SpontaneousOverthrow

Copy link
Copy Markdown
Collaborator

so we need manually add each new workflow? is it possible to scan all workflows?

@SpontaneousOverthrow SpontaneousOverthrow left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we need manually add each new workflow? is it possible to scan all workflows?

Listing each action directory by hand means a new action silently goes
unscanned until someone remembers to add a line - the failure this config
exists to prevent.

A glob does work; the earlier attempt used the wrong one. Dependabot
expands these with Ruby's Dir.glob, where a bare ** behaves as * and
matches a single level, so /.github/actions/** resolved to
.github/actions/docker - a directory holding no action.yml - and matched
nothing. The recursive form is **/*.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

@SpontaneousOverthrow SpontaneousOverthrow left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdozhdev
mdozhdev merged commit 13ee2a5 into main Sep 17, 2026
8 checks passed
@mdozhdev
mdozhdev deleted the fix/dependabot-composite-actions branch September 17, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants